Skip to content

Revert #325 (zspace / ZGamma, FidelityReport z accessors, moments_u32 / observe_batch) - #326

Merged
AdaWorldAPI merged 1 commit into
masterfrom
claude/llvm-codegen-polyfill-gni3cw
Sep 24, 2026
Merged

AdaWorldAPI merged 1 commit into
masterfrom
claude/llvm-codegen-polyfill-gni3cw

Conversation

@AdaWorldAPI

Copy link
Copy Markdown
Owner

What

A 1:1 revert of #325, made with git revert -m 1 e378938. It is one commit, and it touches no other code.

After this revert, the tree is byte-identical to 2c91538, the master state just before #325 merged. git diff 2c91538 HEAD is empty. The diff is the exact mirror of #325: 7 files, +1 / −960.

Removed

  • src/hpc/zspace.rs: ZGamma, ln_det, fisher_z, hyperbolic_depth, hamming_null_z, and the golden digests.
  • pub mod zspace from src/hpc/mod.rs.
  • FidelityReport::{pearson_z, spearman_z, cosine_z} from src/hpc/reliability.rs.
  • moments_u32 / MomentsU32 from src/hpc/statistics.rs.
  • Cascade::observe_batch from src/hpc/cascade.rs.
  • The re-exports of the above from src/simd.rs.
  • The ZGamma golden check in crates/wasm-simd-parity/src/lib.rs.

Verification

  • git diff 2c915389e2a4d9b9048b3546f4a8964c90956fbc HEAD is empty.

🤖 Generated with Claude Code

https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm


Generated by Claude Code

…polyfill-gni3cw"

This reverts commit e378938, reversing
changes made to 2c91538.

Restores the tree of 2c91538 exactly: removes hpc::zspace (ZGamma, ln_det,
fisher_z, hamming_null_z), the FidelityReport z accessors, moments_u32 /
MomentsU32 + Cascade::observe_batch, their simd.rs re-exports, and the
wasm-simd-parity ZGamma golden check.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
@coderabbitai

coderabbitai Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: f6388674-cdf5-419c-bed9-5c436c048bfb

📥 Commits

Reviewing files that changed from the base of the PR and between e378938 and 8c07a54.

📒 Files selected for processing (7)
  • crates/wasm-simd-parity/src/lib.rs
  • src/hpc/cascade.rs
  • src/hpc/mod.rs
  • src/hpc/reliability.rs
  • src/hpc/statistics.rs
  • src/hpc/zspace.rs
  • src/simd.rs
 ________________________________________________________
< Why so serious? Let's put a smile on that code's face. >
 --------------------------------------------------------
  \
   \   (\__/)
       (•ㅅ•)
       /   づ
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@cursor

cursor Bot commented Sep 24, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_8956ad19-7a19-410b-883b-82df5741f120)

@AdaWorldAPI
AdaWorldAPI marked this pull request as ready for review September 24, 2026 15:02
@AdaWorldAPI
AdaWorldAPI merged commit e4d0cf4 into master Sep 24, 2026
25 of 26 checks passed
AdaWorldAPI pushed a commit that referenced this pull request Sep 24, 2026
…325

Mechanical recovery of the HDR/popcount hunks that #326 reverted, applied
unchanged:
- src/hpc/statistics.rs: MomentsU32 (exact integer n / Σx / Σx², order-
  independent merge, exact u128 variance) and moments_u32 (U64x8 lanes,
  split 32-bit squares, 2^28-chunk drain) with their tests.
- src/hpc/cascade.rs: Cascade::observe_batch (Chan-Golub-LeVeque merge of
  batch moments into the rolling floor, per-batch drift alert) with its
  three tests.
- src/simd.rs: the moments_u32 / MomentsU32 re-export line only.

Everything else from #325 stays reverted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants