Revert #325 (zspace / ZGamma, FidelityReport z accessors, moments_u32 / observe_batch) - #326
Merged
Merged
Conversation
…polyfill-gni3cw" This reverts commit e378938, reversing changes made to 2c91538. Restores the tree of 2c91538 exactly: removes hpc::zspace (ZGamma, ln_det, fisher_z, hamming_null_z), the FidelityReport z accessors, moments_u32 / MomentsU32 + Cascade::observe_batch, their simd.rs re-exports, and the wasm-simd-parity ZGamma golden check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches📝 Generate docstrings
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_8956ad19-7a19-410b-883b-82df5741f120) |
AdaWorldAPI
marked this pull request as ready for review
September 24, 2026 15:02
AdaWorldAPI
pushed a commit
that referenced
this pull request
Sep 24, 2026
…325 Mechanical recovery of the HDR/popcount hunks that #326 reverted, applied unchanged: - src/hpc/statistics.rs: MomentsU32 (exact integer n / Σx / Σx², order- independent merge, exact u128 variance) and moments_u32 (U64x8 lanes, split 32-bit squares, 2^28-chunk drain) with their tests. - src/hpc/cascade.rs: Cascade::observe_batch (Chan-Golub-LeVeque merge of batch moments into the rolling floor, per-batch drift alert) with its three tests. - src/simd.rs: the moments_u32 / MomentsU32 re-export line only. Everything else from #325 stays reverted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
A 1:1 revert of #325, made with
git revert -m 1 e378938. It is one commit, and it touches no other code.After this revert, the tree is byte-identical to
2c91538, themasterstate just before #325 merged.git diff 2c91538 HEADis empty. The diff is the exact mirror of #325: 7 files, +1 / −960.Removed
src/hpc/zspace.rs:ZGamma,ln_det,fisher_z,hyperbolic_depth,hamming_null_z, and the golden digests.pub mod zspacefromsrc/hpc/mod.rs.FidelityReport::{pearson_z, spearman_z, cosine_z}fromsrc/hpc/reliability.rs.moments_u32/MomentsU32fromsrc/hpc/statistics.rs.Cascade::observe_batchfromsrc/hpc/cascade.rs.src/simd.rs.ZGammagolden check incrates/wasm-simd-parity/src/lib.rs.Verification
git diff 2c915389e2a4d9b9048b3546f4a8964c90956fbc HEADis empty.🤖 Generated with Claude Code
https://claude.ai/code/session_019HnekoM1EidTwQLS3oFVFm
Generated by Claude Code