Repository navigation
Correct the PR preview docs and cover what was missing - #102
Merged
Merged
Conversation
Several statements about PR previews no longer matched the generated workflows, and behaviour added since 0.24 was undocumented. Fix the broken workflow list, the claim that the Firefox watch shares the preview's setting, and the examples page's description of the publish allowlist. Document what the comment shows, when it is not published and how to publish by hand, and how to regenerate existing workflows safely. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The PR preview documentation now matches what the generated workflows do. This is a docs-only change.
Corrected
FXCSS_OLDEST_FIREFOXsetting.firefox-watch.ymlhas its own copy, so the two can differ.FXCSS_VARIANTSdoes not name specific stylesheets.examples/README.mddescribed a per-theme variant allowlist. The publish workflow now uses a strict name pattern, so later stylesheets need no hand-editing.Added
FXCSS_VIEWSpattern that matches none of a runner's captures fails that platform's render job.a+bcombinations inFXCSS_VARIANTS.initrefuses named editions and themes that need--entry.--forcereplaces only the workflows the command names, and settings you do not pass return to their defaults.Why
The features added since 0.24 were mostly documented, but some statements were wrong and several behaviours a maintainer would run into were not written down.
Notes for reviewers
Testing
python -m unittest tests.test_workflows tests.test_flag_columns tests.test_release_orchestration: 59 tests pass.fxcss initin a disposable repository: all six workflows, rejected settings, empty values, plain--forceand a nested theme, each behaving as documented.🤖 Generated with Claude Code