Repository navigation
Make Pillow a required dependency - #103
Merged
Merged
Conversation
`pipx install fxcss` now installs everything the image commands need. The `images` extra stays, empty, so `fxcss[images]` commands, scripts and generated workflows keep working. fxcss can still run without Pillow from an uninstalled checkout or after `pip install --no-deps`, so the missing-Pillow message and lazy imports stay. The README covers Linux CPUs with no prebuilt Pillow. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
pipx install fxcssis now the whole install. Pillow moves from theimagesextra to a required dependency, socatalogue,compare,check,tweaksandupgrade --comparework without a second step.fxcss[images]stays valid as an empty extra, so existing install commands, scripts and generated workflows keep working. Pinned install lines and workflow templates are unchanged, because older releases still need the extra.pip install --no-deps.scripts/package_smoke.pynow checks that a normal install brings Pillow and that theimagesextra is still declared.Behaviour changes
fxcss shot: 34 images instead of 26, and about 27 seconds longer in the run below. This matches what[images]installs already do.--no-depsworkaround.Testing
Run against wheels built from this branch and from unchanged
main, in Linux arm64 containers.scripts/package_smoke.py, Python 3.9 and 3.14compareon Python 3.9 to 3.15pipxon Ubuntu 24.04 and 26.04, Debian 12 and 13, Alpine 3.24fxcss[images]pipx inject fxcss pillowon an install that already has itfxcss tryon a local folder and onAdamXweb/WhiteSurFirefoxThemeMacOS, Firefox 153 ESR under Xvfbmainfxcss shotandcompare, Firefox ESR under Xvfbfxcss shotwith no displaymainpipx upgradefrom 0.25.0: bare,[images], injected Pillowfxcss[images]==0.10.0, 0.16.2, 0.22.0, 0.25.0 with a newer fxcss availablegit+install from generated workflows[images]--no-binary pillow)comparepasspip install --no-depspipxwith--no-depsNot run: x86_64 (pip resolves a prebuilt Pillow for it, and this PR's CI runs it), real hardware for the CPUs without prebuilt Pillow, NixOS, a Wayland desktop, and older generated workflows on GitHub Actions itself (their install, render and compare commands were run directly).
Existing issue, not changed here: a Pillow compiled without FreeType makes
compareexit with a traceback.[images]installs do the same today, and the README's package list includes FreeType.How to test
python3 -m pip install -e . python3 -m unittest discover -s tests -v python3 -m pip install build python3 -m build python3 scripts/package_smoke.py --dist dist🤖 Generated with Claude Code