Skip to content

Preserve theme customizations and plan maintenance across repository layouts - #91

Merged
AdamXweb merged 2 commits into
mainfrom
feat/fix-theme-maintenance-evaluation
Oct 31, 2026
Merged

AdamXweb merged 2 commits into
mainfrom
feat/fix-theme-maintenance-evaluation

Conversation

@adamXbot

@adamXbot adamXbot commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Themes from the FirefoxCSS Store often use flat, nested, content-only, multi-edition or packaged layouts. This change plans those layouts explicitly, keeps user-added files active across upgrades, and makes recovery, source tracking and setup reporting consistent. It addresses the maintenance findings from the 132-entry evaluation; it does not establish visual compatibility for those themes.

Based on current main, which includes #85 and #88. Nested and flat themes keep repository-wide preview triggers alongside their layout-specific command paths.

Behavior

  • Preservation and recovery: upgrades stage user-added files alongside upstream files, report path collisions before mutation, and record forced displacement in the manifest. Repeated uninstall is a no-op without an active manifest, including when the original profile had no chrome directory. Restoring an inactive backup requires explicit rollback.
  • Layouts: flat, nested, content-only, named editions, ZIP packages and explicitly selected fragments have installation plans. Ambiguous editions require an exact selection. Missing compiled entry imports produce an incomplete-package diagnosis. Repository and theme roots remain separate.
  • Options and preferences: optional sheets retain repository-relative identities through upgrades. Same-name options retain separate files and dependencies; conflicting native import slots are refused, including with force. Chosen preference files are previewed, managed in the removable user.js block and carried forward. Preference-only local changes and explicit setup changes on current remote revisions are detected.
  • Provenance: tracked branches are downloaded and compared at their resolved immutable SHA. Adoption refuses unresolved branch provenance and weak guessed matches. Explicit revision pins survive setup changes. Branch/subpath URLs, renamed repositories, release-versus-branch reporting and the supported GitLab/Forgejo hosts retain their source information.
  • Diagnostics and workflows: installation, audit and discovery share import parsing, including escaped/unquoted targets and conditional imports. Content-only scopes and incomplete analysis are identified. Generated workflows live at the Git root, quote paths safely, and use patches mapped back to the real flat/nested source files. Archives and assembled layouts refuse direct source patch generation.

The source version is now 0.26.0. Nothing is published or tagged by this PR. Generated PyPI pins require that release to exist; fxcss init --toolkit-ref <full commit SHA> supports testing a reviewed toolkit commit before publication.

Validation

  • Full local suite after integrating current main, on Python 3.14 with Pillow: 683 tests, one skipped.
  • All 65 focused workflow, layout, maintenance and smoke regressions also passed with Pillow 10.1.0. The optional-sheet smoke resolves dependencies beside each allocated option directory rather than assuming a fixed install path.
  • Python 3.9: 89 maintenance/inventory/layout tests passed, with the final pin-preservation and Windows patch corrections also checked in all 15 parent-review regressions.
  • Isolated wheel build succeeded; git diff --check is clean.
  • Re-ran discovery/inventory on 23 cached themes, plus 17 targeted lifecycle probes and FlexFox/GNOME import coverage. Native lifecycle cases include flat, nested, content-only, named, ZIP and fragment layouts; unsupported/incomplete sources retain explicit refusals.
  • An additional cached ShyFox probe verified a preference-only simulated update, repeated uninstall with no original chrome directory, and byte-exact restoration of the user's preferences.
  • Synthetic regression tests cover same-name option assets and continuity, collision refusal before mutation, immutable branch downloads/adoption, setup changes on current and pinned revisions, shell metacharacters, and git apply --check/apply from disposable flat/nested repository roots.

CI for the current signed head is reported by this PR's checks. The patch-application regressions emulate Windows newline translation locally, and unified patches are written with LF bytes. Prior-head check results are not claimed for this commit.

Detailed local evidence: /Users/systemadmin/Git/fxcss-maintenance-evaluation-20261030/after-review/ (REVIEW.txt, reevaluation.json, supplemental.json, test/build logs and commit provenance). Cached sources are unchanged; no third-party corpus, credentials or personal profiles are committed.

Limits

  • No live rendering or DOM compatibility verdict for the 132 themes. Local Firefox preflights were blocked; browser-dependent CI smoke checks are not an all-theme visual evaluation.
  • Corpus source changes in the follow-up were simulated, not new pairs of real upstream revisions.
  • check and watch still require the standard layout; init refuses named/fragment layouts. Named-edition assembly supports a plain common-directory copy, not arbitrary installer logic. Downloaded installers, loaders and extensions are never executed or installed automatically.
  • Adoption remains GitHub-only. ZIP/assembled themes need an unpacked source folder for actionable patches. Setup checklist requirements can remain unknown and must not be read as completed configuration.

@adamXbot
adamXbot marked this pull request as draft October 30, 2026 06:58
@adamXbot adamXbot changed the title Plan theme layouts, preserve user files and record truthful provenance Preserve theme customizations and plan maintenance across repository layouts Oct 30, 2026
@adamXbot
adamXbot marked this pull request as ready for review October 30, 2026 07:49
Base automatically changed from fix/review-round-two to main October 30, 2026 10:30
@adamXbot
adamXbot force-pushed the feat/fix-theme-maintenance-evaluation branch from f87c433 to 7ae1e7c Compare October 30, 2026 10:37
…layouts

Plan flat, nested, content-only, named and packaged layouts; preserve user additions and option identities; track immutable source revisions and explicit preferences; and generate workflows and patches for the original repository layout.

Integrate the automation coverage now on main. Keep repository-wide preview triggers alongside nested command paths and toolkit commit pins. Remove obsolete path-filter plumbing and update optional-sheet smoke assertions to locate dependencies relative to the allocated option directory.

Validation: 683 unit tests passed, one skipped. All 65 focused workflow, maintenance and smoke regressions passed with Pillow 10.1.0; Python 3.9 grammar and whitespace checks passed. Real Firefox validation remains in CI.
@adamXbot
adamXbot force-pushed the feat/fix-theme-maintenance-evaluation branch from 7ae1e7c to fa12f99 Compare October 30, 2026 10:58
@AdamXweb
AdamXweb merged commit 42313e6 into main Oct 31, 2026
19 checks passed
@AdamXweb
AdamXweb deleted the feat/fix-theme-maintenance-evaluation branch October 31, 2026 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants