Repository navigation
Preserve theme customizations and plan maintenance across repository layouts - #91
Merged
Merged
Conversation
adamXbot
marked this pull request as draft
October 30, 2026 06:58
adamXbot
marked this pull request as ready for review
October 30, 2026 07:49
adamXbot
force-pushed
the
feat/fix-theme-maintenance-evaluation
branch
from
October 30, 2026 10:37
f87c433 to
7ae1e7c
Compare
…layouts Plan flat, nested, content-only, named and packaged layouts; preserve user additions and option identities; track immutable source revisions and explicit preferences; and generate workflows and patches for the original repository layout. Integrate the automation coverage now on main. Keep repository-wide preview triggers alongside nested command paths and toolkit commit pins. Remove obsolete path-filter plumbing and update optional-sheet smoke assertions to locate dependencies relative to the allocated option directory. Validation: 683 unit tests passed, one skipped. All 65 focused workflow, maintenance and smoke regressions passed with Pillow 10.1.0; Python 3.9 grammar and whitespace checks passed. Real Firefox validation remains in CI.
adamXbot
force-pushed
the
feat/fix-theme-maintenance-evaluation
branch
from
October 30, 2026 10:58
7ae1e7c to
fa12f99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Themes from the FirefoxCSS Store often use flat, nested, content-only, multi-edition or packaged layouts. This change plans those layouts explicitly, keeps user-added files active across upgrades, and makes recovery, source tracking and setup reporting consistent. It addresses the maintenance findings from the 132-entry evaluation; it does not establish visual compatibility for those themes.
Based on current
main, which includes #85 and #88. Nested and flat themes keep repository-wide preview triggers alongside their layout-specific command paths.Behavior
The source version is now 0.26.0. Nothing is published or tagged by this PR. Generated PyPI pins require that release to exist;
fxcss init --toolkit-ref <full commit SHA>supports testing a reviewed toolkit commit before publication.Validation
main, on Python 3.14 with Pillow: 683 tests, one skipped.git diff --checkis clean.git apply --check/apply from disposable flat/nested repository roots.CI for the current signed head is reported by this PR's checks. The patch-application regressions emulate Windows newline translation locally, and unified patches are written with LF bytes. Prior-head check results are not claimed for this commit.
Detailed local evidence:
/Users/systemadmin/Git/fxcss-maintenance-evaluation-20261030/after-review/(REVIEW.txt,reevaluation.json,supplemental.json, test/build logs and commit provenance). Cached sources are unchanged; no third-party corpus, credentials or personal profiles are committed.Limits
checkandwatchstill require the standard layout;initrefuses named/fragment layouts. Named-edition assembly supports a plain common-directory copy, not arbitrary installer logic. Downloaded installers, loaders and extensions are never executed or installed automatically.