Repository navigation
Drop the logo to print the fxcss pick report - #93
Merged
Merged
Conversation
Releasing a dragged logo over an element now picks it, as a click does in `fxcss pick`. A card beside the element prints the CLI's report for the live page: tag and selector, classes with the site's own first, box, notable computed styles, and the matching rules, with rules naming one of its classes first and Tailwind's layered rules marked by layer. It copies the selector and links to the `fxcss pick` documentation. It is a non-modal dialog that takes focus; Escape or its close button returns focus to the logo, and a press elsewhere, a new drag or leaving the page closes it. The logo now lifts only once the pointer leaves it, so a shaky click still goes home. Carrying it back onto itself, releasing outside the page or pressing Escape picks nothing and follows nothing. Each time-machine stop gets its own terminal: an MS-DOS Prompt in 1999, Terminal on Mac OS X in 2003 and an xterm in 2002, with contrast checked for every colour pair. `allowImportingTsExtensions` lets `lib/pick-report.ts` import `./logo-picker.ts`, which Node's test runner needs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GHSA-g3hv-75wg-m249, published on 30 October, affects every minimatch release before 11.0.1 and fails the dependency audit. minimatch reaches the site only through the shadcn CLI, via ts-morph and @ts-morph/common, which asks for minimatch ^10. No 10.x release is patched, and the newest shadcn and ts-morph releases still ask for 10, so an override moves @ts-morph/common to 11.0.3. ts-morph calls only minimatch(path, pattern), which 11 keeps; its glob matching and the shadcn CLI still work. The README notes when to remove the override. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #92. Dropping the dragged logo now does what a click does in
fxcss pick: it picks the element and prints the CLI's report for it.What changes
/docs/pick.<dialog open>that takes focus. Escape or the close button returns focus to the logo. A press elsewhere, a new drag or leaving the page closes it. It is rendered as a sibling of the logo link, so React events from the portal don't reach the link.html[data-retro]rules. The card itself becomes an MS-DOS Prompt (1999,C:\>), Mac OS X Terminal (2003,%) or xterm (2002,$). The pink header stays, as in the real picker. Every text pair meets 4.5:1 and focus rings meet 3:1.tsconfig.jsonenablesallowImportingTsExtensions, solib/pick-report.tscan import./logo-picker.tsunder Node's test runner.Dependency audit fix
CI's audit started failing on GHSA-g3hv-75wg-m249 (published 30 October), which affects every
minimatchrelease before 11.0.1.minimatchcomes only from theshadcnCLI, throughts-morphand@ts-morph/common, which asks for^10. There is no patched 10.x release, and the newestshadcnandts-morphstill ask for 10, so an override moves@ts-morph/commontominimatch11.0.3. ts-morph calls onlyminimatch(path, pattern), which 11 keeps, and its glob matching andnpx shadcnstill work. The README says when to remove the override.Testing
npm run typecheck,npm run lint, andnpm test(40 passing, including rule matching and ordering, report wording, class shortening and the click slop).npm run test:browser: 70 passing in Chromium and Firefox. New cases cover the report and copying, closing by Escape, by a press elsewhere, by a new drag and by the docs link, a shaky click going home, carrying the logo home, Escape mid-drag, and the card in all three time-machine stops.elementFromPointreturnsnull, so nothing is picked.🤖 Generated with Claude Code