Repository navigation
Moza tests: wait for the rim before reading its settings - #15
Merged
Merged
Conversation
The port's thread finds the rim a moment after the base is ready, so the rim test could ask for its settings too early on a slower machine: it failed the v0.2.0-rc.5 release build. It now waits for the rim to answer, and passes with the thread's first poll delayed by 300 ms, where it failed before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rim test asked for the steering wheel's settings as soon as the base was ready. Since the base's serial port has its own thread (#14), the rim is found a moment later, so on a slower machine the test asked too early: it failed the
v0.2.0-rc.5release build (the same commit passed on the PR).The test now waits for the rim to answer. With the thread's first poll delayed by 300 ms, the old test fails exactly as in the release build and the new one passes; the plugin's code is unchanged.
🤖 Generated with Claude Code