Repository navigation
Lay out the home cards' fixed texts only when they change - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profiling the app with devices moving (sampled stacks of the UI thread): about two thirds of the time is Slint drawing the whole window, a third is laying out text, and SimRig's own model code about 3%. Most of the text laid out was text that does not change: a card is one
Devicestruct, rewritten on every live frame, so every text bound to it (name, brand, state chip, strength, rotation, the shifter layout, the handbrake state) was laid out again each time, font lookup included.The cards' fixed texts now follow a local
CardText, set from the samechanged devicehandler as the press badge: a property set to an equal value marks nothing dirty, so they are laid out only when they change.Simulated rig at 30 Hz, app CPU of one core:
What remains is mostly the redraw of the whole window on each frame (about 2.2% at 30 Hz with nothing changing), which FemtoVG does on every frame.