Repository navigation
feat: bump asw 0.12.3 and use asw_add_web_target - #17
Merged
Merged
Conversation
Move the web build to asw_add_web_target from asw 0.12.2. The ASW shell sizes the canvas with CSS, which current ASW needs. The old index.html did not, so the game could draw small and off center in the adsgames.net frame.
Drop the tag and pull request triggers. The Release workflow checks pull requests and ships tags, so no web build runs twice and the second emsdk cache goes away.
|
alegemaate
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps asw from 0.12.1 to 0.12.3 and moves the web build to
asw_add_web_target.index.htmldid not, so in the adsgames.net frame the game could draw small and off center, or show a black screen.asw:statusandasw:readyto the parent page.index.html. Memory flags and--use-preload-pluginsstay.github-pages.ymlruns on pushes tomainonly. The tag and pull request triggers are gone. Release checks pull requests and ships tags, and Pages deploysmain, so no web build runs twice and the second emsdk cache (about 455 MB) goes away.Tested: the web build runs in Chromium inside a 950×712 iframe and on its own. The canvas fills the frame and the load messages arrive. The asw 0.12.3 bump was checked with a web build.