Repository navigation
Conversation
When a spreader in automatic ran full width without receiving any section
setpoint, the log could not tell whether AOG sent all-off section states
or none at all, because PGN 229 was never logged.
- Log AOG's section demand (PGN 229) when it changes, as on-ranges
("4 on: 3-6"), at most every 200 ms, counting changes in between.
- Log when PGN 229 starts and stops arriving; AOG sends it only while a
field is open.
- When an implement is in automatic with sections on, but AOG has asked
for no section for 10 s, log a warning and show it in AOG: either AOG's
section Auto button is off (AOG turns it off on every field open/close)
or no field is open.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In a field log from 2026-10-13, a spreader in automatic spread full width for 47 minutes without receiving a setpoint. The log couldn't tell whether AOG sent all-off section states or none at all, because PGN 229 was never logged. This adds the missing diagnostics, plus a live warning for the operator.
Changes
Demand log: AOG's section demand (PGN 229) is logged when it changes, as on-ranges, at most every 200 ms. Changes in between are counted:
Presence: the TC logs when PGN 229 starts and stops arriving. AOG only sends it while a field is open, so this marks field open/close in the TC log.
Warning: when an implement is in automatic with sections on, but AOG has asked for no section for 10 s, the TC logs a warning and shows it in AOG as a hardware message. The text depends on the cause:
It logs again once the sections follow AOG.
Notes
include/app.hppandsrc/app.cpp; both sides only add code. The resolution is intest/szello-debug.Testing
🤖 Generated with Claude Code