Skip to content

fix(ios): import React Native headers with the React/ prefix (fixes the build on React Native 0.87) - #988

Open
AlicanAkyol wants to merge 2 commits into
AgoraIO-Extensions:mainfrom
AlicanAkyol:fix/react-native-0-87-header-imports
Open

AlicanAkyol wants to merge 2 commits into
AgoraIO-Extensions:mainfrom
AlicanAkyol:fix/react-native-0-87-header-imports

Conversation

@AlicanAkyol

Copy link
Copy Markdown

React Native 0.87 ships its iOS headers as header-only XCFrameworks (prebuilt by default), so a React Native header imported without its React/ namespace is no longer found and the iOS build stops, for example:

react-native-agora/ios/AgoraRtcSurfaceViewManager.mm:2:9: fatal error: 'RCTBridge.h' file not found

This changes those imports to the namespaced form, which every React Native version resolves:

  • ios/AgoraRtcSurfaceViewManager.mm

The release notes describe the change: https://reactnative.dev/blog/2026/08/11/react-native-0.87#headers-breaking-changes

Tested in a new React Native 0.87.1 app (default prebuilt core, Xcode 26.2), building this library's pod target: it fails with 'RCT….h' file not found before the change and builds after it. <React/…> has been the documented form for a long time, so older React Native versions are not affected.

Found while checking popular React Native libraries against 0.87 with NativeKeel, an open-source scanner I maintain; the other libraries that hit this are listed at https://nativekeel.com/fix/rctcomponent-h-file-not-found-react-native-0-87

@ams-ryanolson

Copy link
Copy Markdown

Hit this on Expo SDK 58 / React Native 0.88 too (React Native ships as a prebuilt React.framework there), with react-native-agora 4.6.4 and 4.6.4-build.1: 'RCTBridge.h' file not found in ios/AgoraRtcSurfaceViewManager.mm.

We also changed #import "RCTFabricComponentsPlugins.h" to #import <React/RCTFabricComponentsPlugins.h> in ios/AgoraRtcSurfaceView.mm to be safe, since it is the same unprefixed pattern. Would be great to get this merged and released.

@AlicanAkyol

Copy link
Copy Markdown
Author

Thanks for confirming on Expo SDK 58 / RN 0.88! I added the RCTFabricComponentsPlugins.h change too (cd6020a). React Native 0.88 still re-exposes that header for quoted imports (scripts/cocoapods/rncore_facades.rb), so it isn't strictly needed today, but the <React/...> form works with both source builds and the prebuilt framework without relying on that. It is also the form react-native-screens, react-native-gesture-handler and react-native-pager-view use.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants