Repository navigation
Scan every request cookie, including ones SimpleCookie rejected - #769
Open
iacobdaniel wants to merge 4 commits into
Open
iacobdaniel wants to merge 4 commits into
iacobdaniel wants to merge 4 commits into
Conversation
iacobdaniel
changed the title
timokoessler
approved these changes
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python Zen parsed cookies with SimpleCookie, which drops every cookie as soon as one value contains a space, a comma or JSON, and it read only the last Cookie header. On Starlette and FastAPI, where Zen parses cookies itself, an injection in a cookie like id=1' OR '1'='1 was therefore never scanned. This PR splits each header on ;, keeps every pair and reads every Cookie header, the way those frameworks do, and it's about 10× faster than SimpleCookie. The gap only existed in the Python agent: the other agents either use the framework's own cookies or a parser that keeps every cookie.