Skip to content

fix(ios): request layout on height changes and replay it when resuming native updates #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
farfromrefug merged 2 commits into from
Oct 19, 2026
Merged

fix(ios): request layout on height changes and replay it when resuming native updates #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e03c54
fix(core): replay layout requests suppressed while resuming native up…
farfromrefug Oct 19, 2026
06777ea
fix(ios): request layout when a css property without native setter ch…
farfromrefug Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/core/ui/core/properties/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,9 +834,10 @@ export class CssAnimationProperty<T extends Style, U> implements CssAnimationPro
}
}
}
if (property.affectsLayout) {
view.requestLayout();
}
}
// properties without a native setter (height, width, margins on iOS) still need the layout
if (property.affectsLayout && (computedValueChanged || isSet !== wasSet)) {
view.requestLayout();
}
const eventName = property.eventName;
if (computedValueChanged && (!__UI_USE_EXTERNAL_RENDERER__ || !view._suspendNativeUpdatesCount) && this.hasListeners(eventName)) {
Expand Down
5 changes: 5 additions & 0 deletions packages/core/ui/core/view-base/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,6 +823,11 @@ export abstract class ViewBase extends Observable {
if (!this._suspendNativeUpdatesCount) {
this.onResumeNativeUpdates();
}
if (shouldResumeRequestLayout) {
// layout requests received while suspended were only recorded: replay them now,
// otherwise the next measure reuses the cached size and ignores the changes
this.requestlayoutIfNeeded();
}
}

/**
Expand Down
Loading