Improve audit skills to handle DRY & SOLID principles better - #597
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s audit prompt/skill content to better detect DRY/SOLID and coupling problems (by adding explicit “measure/count first” and “reuse before re-implementing” guidance), and bumps a couple of TypeScript React type dependencies.
Changes:
- Expanded audit guidance to include a “reuse lookup” workflow (project modules → manifest/lockfile → platform) and stronger language around hand-rolled security primitives.
- Standardized/extended structural “count before judging” guidance (now explicitly five counts, including repeated per-file declarations) across prompts, skills, and rules.
- Added prompt character-budget enforcement in the skill publishability checker, and updated
@types/react*versions.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Bumps @types/react and @types/react-dom versions. |
| package-lock.json | Updates lockfile to reflect dependency/version bumps (including transitive updates). |
| CLAUDE.md | Updates documentation of the shared conventions to reflect added structure/reuse guidance. |
| .github/prompts/audit-quality.prompt.md | Adds/strengthens audit-quality rules around reuse checks, structural measurements, and security primitive re-implementation. |
| .github/prompts/audit-pr.prompt.md | Adds guidance for spotting repeated added lines across changed files and expands structural measurement language. |
| .github/copilot-instructions.md | Aligns Copilot instructions with the five-count structure + reuse guidance. |
| .claude/skills/typescript-code-and-test-standards/SKILL.md | Updates skill scope/steps to include reuse checks and the fifth structural count (repeated declarations). |
| .claude/skills/typescript-code-and-test-standards/references/project-detection.md | Clarifies the boundary between “don’t change config for preference” vs “set tool config when the task requires it”. |
| .claude/skills/typescript-code-and-test-standards/assets/copilot-instructions.template.md | Updates the template to reflect “moving directives isn’t deleting” guidance. |
| .claude/skills/audit-quality/SKILL.md | Mirrors prompt updates for audit-quality skill content (reuse + five structural counts). |
| .claude/skills/audit-pr/SKILL.md | Mirrors prompt updates for audit-pr skill content (repeat-line detection + five structural counts). |
| .claude/skills/audit-pr/agents/finding-refuter.md | Extends refutation procedure to cover repeated-declaration findings and prompt-config hoisting cases. |
| .claude/scripts/check-skill-publishability.mjs | Adds prompt character budgets and enforces them during publishability checks. |
| .claude/rules/prompt-skill-sync.md | Documents and explains the new prompt character budgets and why they’re character-based. |
| .claude/rules/code-style.md | Adds repo-specific “structure and reuse” landing rules consistent with the updated skills/prompts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve audit skills to handle DRY & SOLID principles better so it stops repeating code or detects when a code change is too tightly coupled.
Also updated package version numbers.