Skip to content

Improve audit skills to handle DRY & SOLID principles better - #597

Merged
AlexJSully merged 1 commit into
mainfrom
alexjsully-260814-why-audit-skills-be-like-this
Aug 14, 2026
Merged

Improve audit skills to handle DRY & SOLID principles better#597
AlexJSully merged 1 commit into
mainfrom
alexjsully-260814-why-audit-skills-be-like-this

Conversation

@AlexJSully

Copy link
Copy Markdown
Owner

Improve audit skills to handle DRY & SOLID principles better so it stops repeating code or detects when a code change is too tightly coupled.

Also updated package version numbers.

@AlexJSully
AlexJSully requested a lite review from Copilot August 14, 2026 21:49
@AlexJSully AlexJSully self-assigned this Aug 14, 2026
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portfolio Ready Ready Preview Aug 14, 2026 9:50pm

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s audit prompt/skill content to better detect DRY/SOLID and coupling problems (by adding explicit “measure/count first” and “reuse before re-implementing” guidance), and bumps a couple of TypeScript React type dependencies.

Changes:

  • Expanded audit guidance to include a “reuse lookup” workflow (project modules → manifest/lockfile → platform) and stronger language around hand-rolled security primitives.
  • Standardized/extended structural “count before judging” guidance (now explicitly five counts, including repeated per-file declarations) across prompts, skills, and rules.
  • Added prompt character-budget enforcement in the skill publishability checker, and updated @types/react* versions.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
package.json Bumps @types/react and @types/react-dom versions.
package-lock.json Updates lockfile to reflect dependency/version bumps (including transitive updates).
CLAUDE.md Updates documentation of the shared conventions to reflect added structure/reuse guidance.
.github/prompts/audit-quality.prompt.md Adds/strengthens audit-quality rules around reuse checks, structural measurements, and security primitive re-implementation.
.github/prompts/audit-pr.prompt.md Adds guidance for spotting repeated added lines across changed files and expands structural measurement language.
.github/copilot-instructions.md Aligns Copilot instructions with the five-count structure + reuse guidance.
.claude/skills/typescript-code-and-test-standards/SKILL.md Updates skill scope/steps to include reuse checks and the fifth structural count (repeated declarations).
.claude/skills/typescript-code-and-test-standards/references/project-detection.md Clarifies the boundary between “don’t change config for preference” vs “set tool config when the task requires it”.
.claude/skills/typescript-code-and-test-standards/assets/copilot-instructions.template.md Updates the template to reflect “moving directives isn’t deleting” guidance.
.claude/skills/audit-quality/SKILL.md Mirrors prompt updates for audit-quality skill content (reuse + five structural counts).
.claude/skills/audit-pr/SKILL.md Mirrors prompt updates for audit-pr skill content (repeat-line detection + five structural counts).
.claude/skills/audit-pr/agents/finding-refuter.md Extends refutation procedure to cover repeated-declaration findings and prompt-config hoisting cases.
.claude/scripts/check-skill-publishability.mjs Adds prompt character budgets and enforces them during publishability checks.
.claude/rules/prompt-skill-sync.md Documents and explains the new prompt character budgets and why they’re character-based.
.claude/rules/code-style.md Adds repo-specific “structure and reuse” landing rules consistent with the updated skills/prompts.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@AlexJSully
AlexJSully merged commit 32faa39 into main Aug 14, 2026
3 checks passed
@AlexJSully
AlexJSully deleted the alexjsully-260814-why-audit-skills-be-like-this branch August 14, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants