Repository navigation
fix: 🐛 small follow-ups from the reviews of the leak checks, adoption docs and skill - #36
Merged
Merged
Conversation
… from no access - A path git quotes (a double quote, a backslash, a control character) is unquoted, non-ASCII paths are no longer escaped, and the tab git appends to a path with a space in a diff header is dropped. - Output of gh that is not the expected listing skips the check, like a gh that fails, instead of crashing the hook. - When gh lists no non-public repositories the hook says so, rather than that it was skipped. Refs #31 Assisted-by: Pi:claude-opus-5-5
…rking tree Refs #31 Assisted-by: Pi:claude-opus-5-5
… up after the history snippet - The warning about workflows that publish on tag pushes covers tagging a published version too, not only v0.0.0. - The snippet that generates the sections before the baseline runs in a subshell that removes its temporary directory and the worktree even when git-cliff fails. Refs #31 Assisted-by: Pi:claude-opus-5-5
- Read every release, not the first 30. - Compare each inlined CodeArtifact value with its variable in the facts table already. - Widen the old-process docs to any manual step, and the tag-push check to tagging a published version. - Leave rulesets with enforcement disabled or evaluate out of step 8, and give an organisation ruleset handed to an owner a done state. - Name branches-ignore for the release/* checks, set REPO in the handed-over credentials command, count command substitution as a heredoc, and end every report with the commands that were not reads. Refs #31 Assisted-by: Pi:claude-opus-5-5
Contributor
|
This fix isn't in a release yet. To ship it in v1.3.1, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Follow-ups of the reviews of #26–#29.
Leak checks
scripts/check_internal_names.py: paths git quotes (spaces, a double quote, non-ASCII) are reported as named; output ofghthat is not the listing skips the check instead of crashing the hook; an empty listing says "nothing to check" instead of "skipped".tests/test_leaks.py: each tracked file is read once for both repository-wide tests, and a tracked file deleted but not staged is left out.docs/repository-setup.md, step 2v0.0.0.skills/adopt-release-tools/SKILL.mdgh release list --limit 1000; inlined CodeArtifact values compared with their variables in the facts table; the old-process docs row widened to any manual step; the tag-push row covers tagging a published version.enforcementdisabledorevaluatestay out of step 8; an organisation ruleset handed to an owner has a done state.branches-ignorenamed for therelease/*checks;REPOset in the handed-over credentials command; command substitution counts as a heredoc; every report ends with the commands run that were not reads.The public-visibility target and the payload-path note were already in place on
main.Closes #31