[control-operator] disable grpc streams for time being#831
Open
justonedev1 wants to merge 1 commit into
Open
Conversation
knopers8
reviewed
Jul 9, 2026
| // TODO: Streams are not used anywhere now so we turn them off until they are fixed/useful | ||
| // they are not useful for now because any Transition call imediately returns final | ||
| // status. So for now we don't need them. Of course the problem is that if something | ||
| // changes inside OCC container we have no way how to detect it now. |
Collaborator
There was a problem hiding this comment.
I don't quite understand what is broken at the moment. Don't we want to log spontaneous changes in the controlled task, even if we don't react to them?
Collaborator
Author
There was a problem hiding this comment.
we can log those, but the reason why I disabled them was that this actually throws errors, so I threw away this whole thing, with an asterisk to rething and redo it:
It was also the reason why I made this as a TODO and didn't delete it at all. I can make a Jira ticket about it as well if you want.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is nice TODO to fix grpc OCC streams to be useful for task controller, which they aren't now. I just annotated with remark in the code.