Skip to content

Quick bugfix for photon and jet hooks wrt to phi angle in acceptence.#2406

Open
smaff92 wants to merge 230 commits into
AliceO2Group:masterfrom
smaff92:master
Open

Quick bugfix for photon and jet hooks wrt to phi angle in acceptence.#2406
smaff92 wants to merge 230 commits into
AliceO2Group:masterfrom
smaff92:master

Conversation

@smaff92

@smaff92 smaff92 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

No description provided.

smaff92 and others added 30 commits January 30, 2026 17:55
TPC sync. reco. mode with clusters rejection is added is if ALIEN_JDL_DOTPCSYNCMODE=1 env.var is defined.
In this case the original tpc-native-clusters.root file is used as an input to TPC sync. reco. and
overwritten by it.
* respect ALIEN_JDL_WORKFLOWDETECTORS in anchoring python script
* take out TRD from workflow when not readout
* bugfix for fetching options from anchoring JSON (was lacking '--')
* EPOS: Increase number of freeze out events to 10

* Create 13.6 epos configuration

* Fix

* Fix
* MC/PWGEM: add cfg and ini for VM2ll

* Comment out Pythia8 function

Comment out the Pythia8 function to disable it.

* Update pythia8_OO_536_VM2ll.C
* Adjustments for new STARlight version

* Kstar decay
This is to account for the hybro events multiplication in EPOS4 configuration, otherwise the generator will crash at the first generated event.
…2178)

* add POWHEG jet configuration and ini file, pp 13.6 TeV

* select dijet POWHEG process
for the mc-on-data embedding effort
…liceO2Group#2190)

* added exotic particles in the gun

* added exotic particles in the gun

* rolled back to generator_pythia8_longlived.C script to get mass from PDG

* removed formatting changes
* MC/PWGEM: add MC files for HFll in OO

* Rename GeneratorHFGapTriggered_BeautyForcedDecay_Gap2_OO_Electron.ini to lowercase

* Add pdgLepton parameter to generator functions

* Add NEV_TEST condition to generator config

* Add NEV_TEST condition to ini configuration

* Add NEV_TEST configuration to generator ini file

* Add NEV_TEST condition to generator config

* Add NEV_TEST condition to generator config

* Add NEV_TEST condition to generator config

* Fix formatting of NEV_TEST line in config file

* Fix formatting of NEV_TEST line in ini file

* Fix formatting of NEV_TEST line in ini file

* Fix formatting of NEV_TEST line in config file

* Fix formatting of NEV_TEST in ini file

* Update GeneratorHFGapTriggered_Charm_Gap2_OO_muon.ini

* Fix function parameters in generator configuration
didn't have any effect in any case
Remove usage of old `-mod` usage, which in fact didn't have any effect.

Now offer a --skipModules option to explicitely disable modules
in material budget of o2-sim as a more clear solution.

(This will not influence the material budget LUT, so be careful)
missing test macro for PR#2186
sawenzel and others added 27 commits July 14, 2026 11:34
* Create Generator_InjectedInclusiveJpsiPsi2SMidy_2026_Pythia8_TriggerGap.C

* Create Generator_InjectedInclusiveJpsiPsi2SMidy_Pythia8_TriggerGap.C
* [PWGJE] add parametrised model fast sim

* add tests and move to folders

* move inis back to main folder

* mDebug now fetched from config .json
…Jpsi (AliceO2Group#2378)

* Add EVTGEN in HF generator + config for B2Jpsi

* update comment

* Update decays

* Add test macro

* Revert to default test file name

* Fix generator in case of no usage of EVTGEN decayer

* Change number of test events

* Revert number of test events for charm baryon config

* Increase number of test events for SigmaC bkg MC
* Update generator_pythia8_HadronTriggered_withGap.C

* Create Generator_InjectedInclusiveJpsiMidy_Pythia8_TriggerGap.C

* Update Generator_InjectedInclusiveJpsiPsi2SMidy_2026_Pythia8_TriggerGap.ini
* Add missing B_s -> JPsi decays

* remove copy-paste
…s for NeNe (AliceO2Group#2392)

* Add particle data Id for 20Ne in Pythia8

* Injected baryonic resonances nene system

* inject baryonic resonance Lambda(1520) and Xi
* Add diffraction-tuned pythia8 inel cfg

* Adjust default energy to 13.6
)

* Add triggerLc function for Lambda_c particle selection

* Refactor process argument choices in makeStarlightConfig.py

* Add triggerLc function call to makeStarlightConfig.py
…d MC (AliceO2Group#2394)

* PWGDQ: add Ne-Ne prompt charmonia generator configuration

* PWGDQ: add Ne-Ne validation test

* PWGDQ: reduce Ne-Ne trigger gap from 5 to 2
… definitions (AliceO2Group#2400)

* Set the non-prompt injection ratio to 2

Change the default injection ratio from 5 to 2 for the non-prompt gap-triggered generators, corresponding to one injected signal event every two generated events.

* Allow input trigger ratio configuration via environment variable

Read INPUT_TRIGGER_RATIO from the environment and use it to override the default input trigger ratio. Fall back to the constructor default when the variable is unset or invalid.

* Fix EvtGen decay definitions in BTOPSIJPSITODIELECTRON.DEC

Align several inconsistent decay definitions with the standard DECAY.DEC.
This fixes invalid decay models, missing SVV_HELAMP arguments, and incorrect EvtGen particle names. The updated decay table was tested successfully with local event generation.
At the moment impose tuned TRD error and MeanVertex bias related to v10n geometry
only for Pb26 processing (runNumber > 572013)
…2Group#2402)

Following the commit for O-O (see AliceO2Group@c53f5cd) from donglovo, the non-prompt injection ratio has now also made configurable for the p-O case.

I copy here below the description from the commit above, as this one is identical:

* Set the non-prompt injection ratio to 2

Change the default injection ratio from 5 to 2 for the non-prompt gap-triggered generators, corresponding to one injected signal event every two generated events.

* Allow input trigger ratio configuration via environment variable

Read INPUT_TRIGGER_RATIO from the environment and use it to override the default input trigger ratio. Fall back to the constructor default when the variable is unset or invalid.
@smaff92 smaff92 requested a review from a team as a code owner July 14, 2026 02:43
@github-actions

Copy link
Copy Markdown

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@smaff92

smaff92 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Hi,

Apologies, it seems that the commit tree became a bit messy.... still should be fine though, this PR only changes things in the two files for the hooks.

One thing to flag; I did not actually test the changes in the jet hook. It compiles, and should in all probability still work, but it would be nice that the review just gives it a quick check as well, so I did not miss some obvious typo.

Photon hook was tested, and I can confirm that it now interacts correctly with the detector_acceptance.C code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.