[Common] Protect TOF PID tasks against empty collision tables#17048
Merged
dsekihat merged 2 commits intoJul 14, 2026
Conversation
|
O2 linter results: ❌ 26 errors, |
Collaborator
|
Error while checking build/O2Physics/code-check for c7ccd0f at 2026-07-13 18:35: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for da4353f at 2026-07-13 19:49: Full log here. |
dsekihat
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the same protection as #16935 for the TOF PID tasks.
It covers very rare AO2Ds from MC productions that do not contain any reconstructed collision. In these cases, all tracks have
collisionId = 0, while the collision table is empty. The current code can therefore crash when trying to access the 0-th collision entry, which is not allocated.The affected TOF PID paths now check that the collision table is non-empty before dereferencing the collision associated to a track.
Tagging @fgrosa for info!