Skip to content

[PWGEM] Fix clang-tidy warning and errors in more photon meson code#17054

Merged
mhemmer-cern merged 1 commit into
AliceO2Group:masterfrom
mhemmer-cern:emcal-qc
Jul 14, 2026
Merged

[PWGEM] Fix clang-tidy warning and errors in more photon meson code#17054
mhemmer-cern merged 1 commit into
AliceO2Group:masterfrom
mhemmer-cern:emcal-qc

Conversation

@mhemmer-cern

Copy link
Copy Markdown
Collaborator
  • Fix clang-tidy errors and warnings in DalitzEE and EMCal related code

@github-actions github-actions Bot added pwgem photon Photon and neutral meson PAG label labels Jul 14, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 11 errors, ⚠️ 88 warnings, 🔕 18 disabled

- Fix clang-tidy errors and warnings in DalitzEE and EMCal related code

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @mhemmer-cern.

@mhemmer-cern mhemmer-cern merged commit 6510468 into AliceO2Group:master Jul 14, 2026
13 of 15 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for d347b80 at 2026-07-14 21:45:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 6 errors and 0 warnings.'
Found 6 errors and 0 warnings.
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/2e9f14a70cd3190494c6989f5dc1a092e5d37822/O2Physics-code-check/errors.txt
PWGEM/PhotonMeson/TableProducer/skimmerGammaCalo.cxx:261:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerGammaCalo.cxx:271:11: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx:513:44: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx:513:91: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx:615:44: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.cxx:615:91: error: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 6 -gt 0 ]]
++ exit 1
--

Full log here.

@mhemmer-cern mhemmer-cern deleted the emcal-qc branch July 15, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photon Photon and neutral meson PAG label pwgem

Development

Successfully merging this pull request may close these issues.

2 participants