Skip to content

[Tools] Modified MlResponse numInputNodes check: usage of dynamic input#17069

Merged
fcatalan92 merged 1 commit into
AliceO2Group:masterfrom
choich08365:gnnbjet
Jul 15, 2026
Merged

[Tools] Modified MlResponse numInputNodes check: usage of dynamic input#17069
fcatalan92 merged 1 commit into
AliceO2Group:masterfrom
choich08365:gnnbjet

Conversation

@choich08365

@choich08365 choich08365 commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Tools/ML/MlResponse.h

  • Code lines added by lubynet at June 18th disabled the usage of inputs with dynamic sizes, which correspond to numInputNodes == -1. This must be allowed to use models with dynamic inputs, such as the GNN-based b-jet tagger.

Please consider applying this change. Thank you in advance.

@github-actions github-actions Bot added the tools label Jul 15, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Modified MlResponse numInputNodes check: usage of dynamic input [Tools] Modified MlResponse numInputNodes check: usage of dynamic input Jul 15, 2026
@choich08365 choich08365 marked this pull request as ready for review July 15, 2026 02:20
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 1fe67ec at 2026-07-15 04:52:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 7 errors and 0 warnings.'
Found 7 errors and 0 warnings.
++ [[ 7 -gt 0 ]]
++ cat /sw/BUILD/815dcb7488ef042e1824609f29629bdb572dc71a/O2Physics-code-check/errors.txt
Tools/ML/MlResponse.h:166:11: error: implicit conversion 'size_type' (aka 'unsigned long') -> 'bool' [readability-implicit-bool-conversion,-warnings-as-errors]
Tools/ML/MlResponse.h:166:35: error: use 'contains' to check for membership [readability-container-contains,-warnings-as-errors]
Tools/ML/MlResponse.h:282:35: error: initializer for member 'mBinsLimits' is redundant [readability-redundant-member-init,-warnings-as-errors]
Tools/ML/MlResponse.h:283:39: error: initializer for member 'mBinsLimitsVar2' is redundant [readability-redundant-member-init,-warnings-as-errors]
Tools/ML/MlResponse.h:285:28: error: initializer for member 'mCutDir' is redundant [readability-redundant-member-init,-warnings-as-errors]
Tools/ML/MlResponse.h:286:45: error: initializer for member 'mCuts' is redundant [readability-redundant-member-init,-warnings-as-errors]
Tools/ML/MlResponse.h:293:46: error: redundant return statement at the end of a function with a void return type [readability-redundant-control-flow,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 7 -gt 0 ]]
++ exit 1
--

Full log here.

@fcatalan92 fcatalan92 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @choich08365!

@fcatalan92 fcatalan92 merged commit d1ad791 into AliceO2Group:master Jul 15, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants