Skip to content

[PWGLF] fix Event_split correction and add secondary-origin split for primary-fraction correction in ptmultCorr#17083

Open
akyadav1963 wants to merge 1 commit into
AliceO2Group:masterfrom
akyadav1963:ptmult-evtloss-sigloss-corrections
Open

[PWGLF] fix Event_split correction and add secondary-origin split for primary-fraction correction in ptmultCorr#17083
akyadav1963 wants to merge 1 commit into
AliceO2Group:masterfrom
akyadav1963:ptmult-evtloss-sigloss-corrections

Conversation

@akyadav1963

Copy link
Copy Markdown
Contributor

Changes:

  1. Split non-primary reconstructed tracks into weak-decay (TMCProcess::kPDecay) and material-interaction origins, replacing the previous K0s/Λ-only mother check. Added kRecoMaterial bin; kRecoSecondary retained as a weak+material union cross-check.
  2. Corrected the placement of the event-selection cuts and the event-split histogram filling.

@github-actions github-actions Bot added the pwglf label Jul 16, 2026
@github-actions github-actions Bot changed the title PWGLF: fix Event_split correction and add secondary-origin split for primary-fraction correction in ptmultCorr [PWGLF] fix Event_split correction and add secondary-origin split for primary-fraction correction in ptmultCorr Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@akyadav1963 akyadav1963 force-pushed the ptmult-evtloss-sigloss-corrections branch from 8115124 to e846ce4 Compare July 16, 2026 06:27
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e846ce4 at 2026-07-16 08:47:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 18 errors and 45 warnings.'
Found 18 errors and 45 warnings.
++ [[ 18 -gt 0 ]]
++ cat /sw/BUILD/ce731aae9fb42261679604e6c08ee984cca32783/O2Physics-code-check/errors.txt
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:38:1: error: included header TH2.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:66:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:74:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:89:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:100:1: error: initial values in enum '<unnamed>' are not consistent, consider explicit initialization of all, none or only the first enumerator [readability-enum-initial-value,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:117:10: error: variable 'axisEvent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:118:10: error: variable 'axisVtxZ' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:119:10: error: variable 'axisEta' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:120:10: error: variable 'axisPhi' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:121:10: error: variable 'axisPhi2' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:122:10: error: variable 'axisCent' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:123:10: error: variable 'axisDeltaPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:124:10: error: variable 'axisDCAxy' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:125:10: error: variable 'axisGenPtVary' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:127:10: error: variable 'axisGenTrkType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:128:10: error: variable 'axisRecTrkType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:129:10: error: variable 'axisTrackType' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:132:8: error: constructor does not initialize these fields: pdg [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
++ [[ 45 -gt 0 ]]
++ cat /sw/BUILD/ce731aae9fb42261679604e6c08ee984cca32783/O2Physics-code-check/warnings.txt
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:324:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:329:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:334:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:340:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:346:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:352:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:358:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:364:70: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:369:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:377:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:418:42: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:490:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:518:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:558:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:632:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:717:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:778:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:846:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:849:24: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:851:56: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:853:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGLF/Tasks/GlobalEventProperties/ptmultCorr.cxx:855:43: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@akyadav1963 akyadav1963 force-pushed the ptmult-evtloss-sigloss-corrections branch from e846ce4 to 1aecc3b Compare July 16, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants