[PWGJE] pvalue check on rho(phi)#17106
Open
joachimckh wants to merge 5 commits into
Open
Conversation
|
O2 linter results: ❌ 1 errors, |
joachimckh
marked this pull request as ready for review
July 17, 2026 11:16
joachimckh
requested review from
alibuild,
fjonasALICE,
jaimenorman,
mhemmer-cern and
nzardosh
as code owners
July 17, 2026 11:16
Collaborator
|
Error while checking build/O2Physics/code-check for 05ebb3e at 2026-07-17 13:36: Full log here. |
vkucera
reviewed
Jul 19, 2026
Comment on lines
608
to
+610
| LOGF(fatal, "Could not find %s as TH1F in track efficiency list %s", efficiencyName.c_str(), cfgEfficiency.value.c_str()); | ||
| } | ||
| LOGF(info, "Loaded tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency.value.c_str(), (void*)cfg.hEff); | ||
| LOGF(info, "Loaded tracking efficiency %s from %s (%p)", efficiencyName.c_str(), cfgEfficiency.value.c_str(), static_cast<void*>(cfg.hEff)); |
Collaborator
There was a problem hiding this comment.
Don't use void*. This is C++, not C.
vkucera
reviewed
Jul 19, 2026
| @@ -1480,6 +1480,15 @@ struct JetSpectraEseTask { | |||
| return nullptr; | |||
|
|
|||
| auto cDF = 1. - TMath::Gamma(nDF, chi2); | |||
| if constexpr (fillHist) | |||
| registry.fill(HIST("eventQA/hRhoPhiCheck"), 0.5); | |||
| if (cfgRhoPhiPvalCriteria && cDF < 0.01) { | |||
Collaborator
There was a problem hiding this comment.
The magic number is here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.