Conversation
dajinchu
commented
Sep 18, 2026
dajinchu
commented
Collaborator
- Fix history nav breaking after entering on a native page
- Install a single vike and fix hardNavigate return type
The lockfile kept vike 0.4.255 hoisted at the root for vike-react's peer range while bifrost and tests/vite nested 0.4.259. bifrost-fastify resolved the root copy, so `renderPage` ran on a different vike than the built app. The first request after every server boot failed with a Vike "Bug" assertion; CI only passed thanks to retries. npm never hoisted 0.4.259 because a prerelease tag does not satisfy vike-react's `>=0.4.250`. Pin vike at the workspace root and override it so every workspace shares one copy, and align bifrost-fastify's peer and dev dependency with bifrost. Also return the never-settling promise from hardNavigate so `tsc` stops reporting a reachable end point in a function returning `never`. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dajinchu
force-pushed
the
dc/fix-version
branch
from
September 18, 2026 17:10
f72bdd2 to
0b548f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.