Skip to content

fix: make sure that multiple CHECK-NOT lines are all checked - #1355

Merged
nunoplopes merged 1 commit into
AliveToolkit:masterfrom
regehr:regehr/check-not-fix
Sep 21, 2026
Merged

nunoplopes merged 1 commit into
AliveToolkit:masterfrom
regehr:regehr/check-not-fix

Conversation

@regehr

@regehr regehr commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

currently only the first CHECK-NOT directive in our test files is actually checked.

for example, run this lit test in our current repo and it passes! of course it should not pass. it does not pass after this PR is merged.

; TEST-ARGS: -quiet

define i32 @src(i32 %x) {
  ret i32 %x
}

define i32 @tgt(i32 %x) {
  %y = add i32 %x, 0
  ret i32 %y
}

; CHECK-NOT: bla-this-string-never appears
; CHECK-NOT: Transformation seems to be correct!

@nunoplopes
nunoplopes merged commit 88bc283 into AliveToolkit:master Sep 21, 2026
16 checks passed
@regehr
regehr deleted the regehr/check-not-fix branch September 21, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants