Skip to content

feat: support for multiple vscales per run - #1362

Closed
regehr wants to merge 1 commit into
AliveToolkit:masterfrom
regehr:regehr/vscale3
Closed

regehr wants to merge 1 commit into
AliveToolkit:masterfrom
regehr:regehr/vscale3

Conversation

@regehr

@regehr regehr commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

so the basic approach here is to check if src or tgt actually uses vscale, and if not to behave as before. if so, we use the typechecker to enumerate vscale values.
I'm not in love with the code, I think it works but I think doing this through the solver isn't any better than just enumerating in C++, or is there a way I should be doing this better?

@nunoplopes

Copy link
Copy Markdown
Member

I really don't like this approach, sorry.
Why is it not using the type inference mechanism? It's much simpler.
See the IntType::getTypeConstraints & IntType::fixup. That's all you need changing (for AggregateType).

@regehr regehr closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants