Skip to content

feat: Handle FMS (/allen/programs) paths - #508

Merged
ShrimpCryptid merged 2 commits into
mainfrom
fix/handle-fms-paths
Nov 16, 2026
Merged

ShrimpCryptid merged 2 commits into
mainfrom
fix/handle-fms-paths

Conversation

@ShrimpCryptid

Copy link
Copy Markdown
Contributor

Problem

Adds support for remapping FMS paths to their S3 bucket equivalent.
Estimated review size: tiny, 5 minutes

@toloudis toloudis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, both my comments are nits

});

it("maps FMS file paths", () => {
expect(remapUri("/allen/programs/allencell/data/proj0/folder/some-data.ome.zarr")).toBe(

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible someone coming from a Windows'y world would put this in with a double-forward-slash at the beginning? or do we handle that elsewhere?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do handle this in vole-app currently, yes. I could also copy in the code that handles that if we want to repeat it in both places.

Comment thread src/utils/url_utils.ts Resolved
@ShrimpCryptid
ShrimpCryptid merged commit f125735 into main Nov 16, 2026
5 checks passed
@ShrimpCryptid
ShrimpCryptid deleted the fix/handle-fms-paths branch November 16, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data-loading enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants