You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up housekeeping identified while reviewing the CI run for raster-store persistence:
Make sanitizer findings fail CI and resolve the OpenCV reports. The clang-23-asan job also enables LeakSanitizer and UBSan, but UBSan findings currently recover and the job passes. OpenCV 4.11 reports a function-pointer type mismatch in core/src/rand.cpp and an invalid IppiInterpolationType value in imgproc/src/resize.cpp. Try upgrading OpenCV to 4.14, use a narrowly scoped ignorelist for any remaining confirmed upstream diagnostic, set UBSAN_OPTIONS=halt_on_error=1:print_stacktrace=1, and rename the job to clang-23-asan-ubsan.
Run every test executable built by CI. Add unittests_sfbuilder_finalization and unittests_tile_downloader to the workflow test step. Longer term, register the executables with CTest and use ctest --output-on-failure so the workflow does not maintain a separate list.
Silence expected errors locally in tests. Invalid-input tests currently emit hundreds of expected PROJ/GDAL errors plus the expected malformed-attribution JSON error. Use scoped GDAL/CPL error-handler suppression around calls that intentionally provide invalid input; keep unexpected diagnostics visible.
Remove the external GEOS header warnings. Clang reports deprecated whitespace before the _json and _json_pointer literal operators in GEOS's bundled JSON header. Upgrade GEOS and verify the warning disappears; otherwise pass -Wno-deprecated-literal-operator only to the external GEOS build.
Reduce external CMake warning noise. Dependency configuration emits policy/deprecation warnings from CGAL, cpptrace, zstd, libdwarf, libigl/triangle, GLM, tinygltf, and cmrc, plus unused cache-variable warnings in external TBB/GEOS builds. Suppress developer warnings only for external configure steps, update dependencies when practical, and make alp_setup_cmake_project forward only configuration variables relevant to the active external build.
Follow-up housekeeping identified while reviewing the CI run for raster-store persistence:
Make sanitizer findings fail CI and resolve the OpenCV reports. The
clang-23-asanjob also enables LeakSanitizer and UBSan, but UBSan findings currently recover and the job passes. OpenCV 4.11 reports a function-pointer type mismatch incore/src/rand.cppand an invalidIppiInterpolationTypevalue inimgproc/src/resize.cpp. Try upgrading OpenCV to 4.14, use a narrowly scoped ignorelist for any remaining confirmed upstream diagnostic, setUBSAN_OPTIONS=halt_on_error=1:print_stacktrace=1, and rename the job toclang-23-asan-ubsan.Run every test executable built by CI. Add
unittests_sfbuilder_finalizationandunittests_tile_downloaderto the workflow test step. Longer term, register the executables with CTest and usectest --output-on-failureso the workflow does not maintain a separate list.Silence expected errors locally in tests. Invalid-input tests currently emit hundreds of expected PROJ/GDAL errors plus the expected malformed-attribution JSON error. Use scoped GDAL/CPL error-handler suppression around calls that intentionally provide invalid input; keep unexpected diagnostics visible.
Remove the external GEOS header warnings. Clang reports deprecated whitespace before the
_jsonand_json_pointerliteral operators in GEOS's bundled JSON header. Upgrade GEOS and verify the warning disappears; otherwise pass-Wno-deprecated-literal-operatoronly to the external GEOS build.Reduce external CMake warning noise. Dependency configuration emits policy/deprecation warnings from CGAL, cpptrace, zstd, libdwarf, libigl/triangle, GLM, tinygltf, and cmrc, plus unused cache-variable warnings in external TBB/GEOS builds. Suppress developer warnings only for external configure steps, update dependencies when practical, and make
alp_setup_cmake_projectforward only configuration variables relevant to the active external build.Evidence: https://github.com/adam-ce/alpine-terrain-builder/actions/runs/34444586550 — all five matrix jobs passed; these are non-fatal maintenance findings from the logs.