Repository navigation
Conversation
…ling blas/lapack directly
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will hopefully allow #1204 to finish.
Some archaic function definitions in the bundled readline library were causing compilation failures with gcc 15 (see e.g. https://github.com/Amber-MD/cpptraj/actions/runs/43675246915/job/132693837313?pr=1204). This PR fixes some of these old function definitions to allow readline to compile.
Also introduces a new configure flag,
-makerl, which forces cpptraj to use the bundled readline even if system readline is present (I didn't catch this problem originally because even though I tested with gcc 15 I was pulling in the system readline automatically).No version bump since it doesn't touch any cpptraj code.