Skip to content

Fix old function definitions in bundled readline - #1205

Open
drroe wants to merge 4 commits into
Amber-MD:masterfrom
drroe:fix.ghActions
Open

drroe wants to merge 4 commits into
Amber-MD:masterfrom
drroe:fix.ghActions

Conversation

@drroe

@drroe drroe commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

This will hopefully allow #1204 to finish.

Some archaic function definitions in the bundled readline library were causing compilation failures with gcc 15 (see e.g. https://github.com/Amber-MD/cpptraj/actions/runs/43675246915/job/132693837313?pr=1204). This PR fixes some of these old function definitions to allow readline to compile.

Also introduces a new configure flag, -makerl, which forces cpptraj to use the bundled readline even if system readline is present (I didn't catch this problem originally because even though I tested with gcc 15 I was pulling in the system readline automatically).

No version bump since it doesn't touch any cpptraj code.

@drroe drroe self-assigned this Nov 15, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant