Skip to content

fix(payments): require password for all sends [AMB-3265] - #55

Merged
wthrajat merged 2 commits into
mainfrom
jesseva/amb-3265-require-password-for-all-sends
Sep 24, 2026
Merged

wthrajat merged 2 commits into
mainfrom
jesseva/amb-3265-require-password-for-all-sends

Conversation

@bufo24

@bufo24 bufo24 commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Summary

  • require a non-empty password for every SDK send, including sandbox
  • allow any non-empty sandbox placeholder such as Password123 because sandbox does not use the value
  • require the real team password for live sends
  • reject missing or blank passwords before wallet lookup or transaction creation
  • keep prepared credentials scoped to retryPayment and update SDK documentation/examples

Testing

  • 61 payments tests passed for the original change
  • 13 focused send/preparation tests passed after the placeholder clarification
  • payments TypeScript typecheck passed
  • ESM and CommonJS builds passed
  • CommonJS examples typecheck passed
  • formatting checks passed

Linear: https://linear.app/amboss/issue/AMB-3265/require-team-password-for-sandbox-and-production-payments-sdk-sends

@bufo24
bufo24 force-pushed the jesseva/amb-3265-require-password-for-all-sends branch from dc401a8 to d24db52 Compare September 24, 2026 11:14
@wthrajat
wthrajat merged commit bb50f3b into main Sep 24, 2026
2 checks passed
@apotdevin apotdevin mentioned this pull request Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants