Repository navigation
Add strict broken-link checks and bundle-path compatibility - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Protocol-relative external links may be misclassified as bundle paths by strict validation.
Review effort: Lite
Findings: None
What changed in this PR
Adds strict broken-link validation, legacy /brain/... viewer compatibility, documentation, regression tests, and CI enforcement.
Changes:
- Validates links with canonical-path suggestions.
- Adds frontend fallback resolution and canonical tooltips.
- Documents link conventions and runs strict checks in CI.
| File | Description |
|---|---|
tests/test_validation.py |
Tests validation and prefix suggestions. |
tests/test_cli.py |
Tests strict CLI behavior. |
src/Detail.test.js |
Tests recovered-link rendering. |
src/Detail.jsx |
Displays canonical tooltips for recovered links. |
src/brain.test.js |
Tests fallback resolution and backlinks. |
src/brain.js |
Implements compatibility resolution and graph handling. |
skills/okf/templates/concept.md |
Adds canonical-link guidance. |
skills/okf/onboarding-SKILL-peer-to-peer.md |
Documents link and validation requirements. |
skills/okf/onboarding-SKILL-centralized.md |
Documents link and validation requirements. |
README.md |
Documents link rules and CI checks. |
okf_tools/validation.py |
Adds reserved-file link validation and prefix suggestions. |
.github/workflows/check-brain.yml |
Adds strict validation CI. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/brain/...viewer links while displaying canonical-path tooltips.Testing
python -m okf_tools check brainon Python 3.11.