[fix][relayer][core] isolate receipt confirmation failures - #82
Draft
fengjy73 wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sdp_msg_poolrow IDExecutionExceptionto the affected receipt so the remaining futures in the confirmation batch still commitTX_PENDINGfor the next reconciliation passInterruptedException, because worker interruption is not a transaction-local failureRoot cause
The confirmation worker already loaded each pending SDP row and therefore knows its primary key. It nevertheless
built terminal results without that ID, forcing the repository to fall back to a product/blockchain/transaction-hash
lookup. A plugin may return a native transaction-hash representation that does not match the pending-row lookup
shape, leaving a genuinely confirmed transaction pending.
The same loop called
Future.get()inside one outer batch and rethrew everyExecutionException. One temporarilymissing or unavailable native receipt therefore discarded the confirmed results collected from other futures in
that pass. The next pass retried all of them and could also delay downstream execution reports.
Validation
AMConfirmServiceagainst the upstream production-compatible class setAMConfirmServiceTest: 3 tests passedgit diff --checkpassedThe full local reactor also reached
r-corecompilation, but this workstation currently has a newer regulatoryantchain-bridge-spisnapshot cached locally. That snapshot addsISDPWriter.setMonitorContract, which upstreamGRpcBBCServiceClientdoes not implement; the unrelated interface mismatch prevents a clean full-reactor resultwithout modifying files outside this PR. No compatibility stub is included here.