Repository navigation
fix(ci-node): build what the tests read in Stress again with typecheck - #104
Merged
Merged
Conversation
#93 left only checks:prepare in the Stress build step. A caller whose tests read the output of typecheck, such as dms-saas and its dist/, failed every Stress run of the nightly tier since.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ANT-3515. Goal: every nightly
ci.ymlrun is green, Windows legs included. This pull request sorts the failures of the 2026-11-20 nightlies by cause and fixes the one shared cause still live in this repository.What was broken. Since 2026-11-20,
Stressin dms-saas has failed on every run withError: dist/ is missing: run the build before this check.#93 (merged 2026-11-19 05:59 UTC) cut theStressbuild step fromchecks:prepare+typecheckdown tochecks:prepareonly. dms-saas builds itsdist/intypecheck, and itstestscript reads thatdist/. In the Node.js job,pnpm run checksrunstypecheckbefore the tests, so that job still passes.Stressruns nochecks, so its tests found no build. The 11-19 nightly ran the workflow from before #93 and passed. The 11-20 nightly ran it from after #93 and failed all 3 runs.Fix.
Stressrunspnpm run --if-present typecheckafterchecks:prepareagain, as #71 first designed it.--if-presentmeans a caller with notypecheckscript still passes. The README paragraph onStressnames the step. No input, default, secret or permission changes, so callers need no edit.The other shared cause, GitHub billing, needs no change here: see the table and the note under it.
Nightly failures of 2026-11-20, by cause
History covers each repository's scheduled runs from 11-16 to 11-20, all it has. Steady means the same cause failed two or more nights in a row up to 11-20. Flaky means it failed once, or in 1 of the 3
Stressruns, and passed on other nights. New means 11-20 was the first failure, too soon to say.windows: falseon purpose (test-module-cloud#7: its only test is the build)Stressdist/missing: #93 droppedtypecheckfrom theStressbuildStressajs project start while another run rebuilds and prunes(start-build-race test) times out at 5000 ms under load, 3 of 3 runsStressAntelopeTestConfig.setuptests time out at mocha's default 2000 ms under load, 3 of 3Stressbefore allhooks oftodo APIandtask ownership(project boot) time out at 2000 ms under load, 3 of 3Stressgroup mapper orderBy on an array keytimes out at 10000 ms under load, 3 of 3Stress[fallback] a subscription that keeps failing to processfails an equality assertion under load, 1 of 3Stressred each night)Stressregistration.test.ts > names the explorer block by the name the DMS serves it undertimes out at 5000 ms, 1 of 3Stressred each night)Stress;Node 22/24 on Windowsprobetests (many relations, slow URL value) time out under load. Windows:.agents/skills/formal-*/check.mjscallsspawnSync("pnpm")with no shell →spawn pnpm ENOENTStress;Node .nvmrc on Windowsaccess write-backproperty test,data journeysanddiagram layout routestime out at 2000 ms. Windows: the rootbefore allseed hook times out at 2000 msTest .nvmrc on Windows;vitest (windows-latest, sidecar).agents/skills/formal-*/check.mjscallsspawnSync("pnpm")with no shell →spawnSync pnpm ENOENT; the sidecar'stool-guardandsession-tool-results-readtests fail on WindowsTest .nvmrc on Windows;backend (windows-latest, builder:1-3/5)EPERMrenamingrun.json.nextoverrun.json,write ECONNRESET; builder:a declaration file edited between two builder operationsis not re-parsedStressflaky (11-17, 11-19)Node .nvmrc on Windowstests/package.test.mjsreads thepnpm packoutput as JSON and getsUnexpected end of JSON inputon Windowsbackend-tests on Windowsafter allhookremoveRunUnlessFailedtimes out at 2000 ms on WindowsTest .nvmrc on Windowsbefore allhook connects to the S3 service at127.0.0.1:5005, which Windows legs do not start (ECONNREFUSED)Stressformal-route-treetest times out at 2000 ms, 1 of 3Stress[mollie] the hosted page languagegetsundefinedfor the payer's language after the stand-in webhook answered "temporarily unavailable", 1 of 3e2e (2)/for 3 min · checked hh:mm:ss/depends on wall-clock timeOn 11-19 only, the e2e
frontend-buildstep failed in dms-mailing, dms-media and dms-saas the same night. It passed on 11-20 with no change here, so it is not counted above.Billing. The six private repositories ran no job on 11-19 and 11-20 (GitHub's annotation, quoted above). #103 merged at 03:45 UTC on 11-20, after that night's run at 02:17 (the run's
referenced_workflowsnamesfb14e4f). It moved their Linux legs,Stressandchecksontoantelope-ci. Manual runs at 03:47 UTC passed onantelope-ci(cdn, brevo-private, mqtt). Their nightly Windows legs still need GitHub-hostedwindows-latest, so they stay red while billing refuses jobs. Antony settles the billing; this repository changes nothing for it.Related issue
ANT-3515, items 1 and 3 of its Scope. The change reaches callers when
v2moves to its merge commit.Verification
The
Stresssteps run locally on a fresh clone of dms-saas (b11f00a), Node 24.22.2, pnpm 10.34.9, afterpnpm install --frozen-lockfile.Before,
main's steppnpm run --if-present checks:prepare, thenCI=1 pnpm run test:After, the step's
runtext parsed out of this branch'sci-node.yml, thenCI=1 pnpm run test:actionlint .github/workflows/*.yml(1.7.12): no output, exit 0.PNPM=$(command -v pnpm) node --test scripts/ci-tier/*.test.ts, which readsci-node.yml: 75 pass, 0 fail.No manual run can reach
Stress: only ascheduleevent gives thenightlytier. The first nightly afterv2moves is the end-to-end check.Follow-ups
windows: falseand no skip in ci-node.yml. Done means: their next nightly runs its Windows legs.start-build-racetest times out at 5000 ms underStress. Done means:Stresspasses 3 of 3 runs.AntelopeTestConfig.setuptests time out at 2000 ms underStress. Done means:Stresspasses 3 of 3 runs.before allproject boot times out at 2000 ms underStress. Done means:Stresspasses 3 of 3 runs.group-orderby-array-sorttimes out at 10000 ms underStress. Done means:Stresspasses 3 of 3 runs.[fallback] a subscription that keeps failing to processfails underStress. Done means:Stresspasses 3 of 3 runs.registration.test.tsexplorer block test times out at 5000 ms underStress. Done means:Stresspasses 3 of 3 runs.formal-*/check.mjsspawnspnpmwith no shell (ENOENT on Windows), and theprobetests time out underStress. Done means: the Windows legs andStresspass.access write-back,data journeysanddiagram layout routestests time out underStress, and the Windowsseedhook times out at 2000 ms. Done means:Stressand the Windows leg pass.formal-*/check.mjsspawnspnpmwith no shell (ENOENT on Windows), and the sidecar'stool-guardandsession-tool-results-readtests fail on Windows. Done means: both Windows jobs pass.EPERMon therun.jsonrename,ECONNRESET), and builder shards 1-3 faila declaration file edited between two builder operations. Done means: the Windows jobs pass.tests/package.test.mjsgets emptypnpm packJSON on Windows. Done means: the Windows leg passes.removeRunUnlessFailedtimes out at 2000 ms on Windows. Done means:backend-tests on Windowspasses.formal-route-treetest times out at 2000 ms underStress. Done means:Stresspasses 3 of 3 runs.the hosted page languageloses the payer's language after a stand-in webhook error underStress. Done means:Stresspasses 3 of 3 runs.e2epasses on reruns at any minute.windows: falsehas no comment saying why. Done means: eachci.ymlstates its reason beside the input.Checklist
Stresssteps; the proof above runs them.Skills
no skill change