Skip to content

ci: run Windows only for public callers, release private ones on RUNNER_CI, keep 0.x minors manual - #107

Merged
Upd4ting merged 1 commit into
mainfrom
ci/wec9b4589-35-public-only-hosted-runners
Nov 20, 2026
Merged

Upd4ting merged 1 commit into
mainfrom
ci/wec9b4589-35-public-only-hosted-runners

Conversation

@Upd4ting

Copy link
Copy Markdown
Member

Task: Wec9b4589-35

Summary

Why

Private AntelopeJS repositories (brevo-private, cdn, dms-antelope-cloud, mailchimp, mqtt, test-module-cloud) are blocked on their Windows legs and on Release by GitHub billing. AntelopeJS has no Windows runner of its own, and a private repository pays for GitHub-hosted minutes. On 2026-11-20, Antony decided three things:

  1. Windows jobs run only on public repositories.
  2. The release workflows run on the org's runners (vars.RUNNER_CI) for private and internal repositories. Public repositories stay on ubuntu-latest, which npm provenance needs.
  3. Renovate keeps 0.x minor updates manual, since a 0.x minor can break. feat(module-locks): share the lock refresh, lock check and Renovate lock commit, and update the Renovate preset #106 turned on auto-merge for patch and minor updates. That stays for 1.x and later.

What

  • ci-node.yml: the matrix adds windows-latest only when github.event.repository.visibility == 'public', in every tier (nightly, merge queue, manual). The windows input description and the README say so. Since 2022, scheduled runs carry github.event.repository too, so the nightly tier reads the same field.
  • release-npm.yml (called by release-npm-public.yml and release-npm-private.yml): runs-on: ${{ github.event.repository.visibility != 'public' && vars.RUNNER_CI || 'ubuntu-latest' }}. The job uses gh, jq, tar, git, setup-node and pnpm, all of which next-sync.yml already uses on RUNNER_CI. The npm-publish environment works on self-hosted runners. A private caller without RUNNER_CI stays on ubuntu-latest. No other shared job that a caller reaches is still hard-coded to ubuntu-latest: ci-metrics-*, link-rot, templates-fresh-clone and release-train-checks run only in this repository.
  • renovate.json5: a rule after the auto-merge rule sets automerge: false for matchUpdateTypes: ['minor'] with matchCurrentVersion: '/^v?0\\./'. The regex matches the resolved current version, so it works for a pinned value (0.4.0), a range (^0.4.0, via the locked or current version) and an action tag (v0.4.0). A semver range (<1.0.0) would not work: under Renovate's default semver-coerced versioning, <1.0.0 coerces to a version and the rule never matches.
  • Tests:
    • scripts/release-train/workflows.test.ts evaluates the release job's runs-on and the ci-node os matrix over visibility, event and the windows* inputs. Its evaluate helper now knows vars and fromJSON.
    • scripts/module-locks/renovate-preset.test.ts gives every upgrade a currentVersion and adds a 0.x case, using Renovate's own applyPackageRules.
  • The callers are unchanged: no input, default, secret or permission moved. The workflow changes reach callers once v2 moves. Renovate reads renovate.json5 from main, so the 0.x rule applies as soon as this merges.
flowchart TD
  E[caller event] --> V{github.event.repository.visibility}
  V -->|public| P1[ci-node: Linux plus windows-latest in its tiers]
  V -->|public| P2[release: ubuntu-latest, npm provenance]
  V -->|private / internal| Q1[ci-node: Linux on RUNNER_CI only, no Windows]
  V -->|private / internal| Q2[release: RUNNER_CI, else ubuntu-latest]
Loading

Related issue

Wec9b4589-35 (no Notion page). Follows ANT-3514 and ANT-3515.

Verification

Workflow tests, node --test 'scripts/release-train/workflows.test.ts'. Before, with ci-node.yml and release-npm.yml from main:

✖ the job runs on the caller's RUNNER_CI runner for a private or internal repository when it is set, and on ubuntu-latest otherwise, and always for a public one
✖ Windows legs join the matrix only for a public repository, and only in the tiers that ran them before
ℹ tests 43
ℹ pass 41
ℹ fail 2

After:

ℹ tests 43
ℹ pass 43
ℹ fail 0

The full release train suite (scripts/release-train/*.test.ts) gives 134 pass, 0 fail. tsc is clean for both script folders, and actionlint 1.7.12 is clean on .github/workflows/*.yml.

Preset test, node --test 'scripts/module-locks/renovate-preset.test.ts' with renovate 44.247.1. Before, with renovate.json5 from main:

✖ a 0.x minor stays manual, while a 0.x patch and a minor from 1.x on merge on their own
  AssertionError [ERR_ASSERTION]: 0.4.0
ℹ pass 7
ℹ fail 1

After:

ℹ pass 8
ℹ fail 0

renovate-config-validator --strict --no-global renovate.json5 passes.

Real Renovate run (renovate 44.257.5, --platform=local --dry-run=lookup). The fixture repository extends the preset and holds @antelopejs/interface-core ^0.4.0, @antelopejs/interface-database 0.4.0, dotenv 8.2.0, and an antelope.config.ts pin of interface-core 0.3.0. The run prints each branch's automerge. Before:

renovate/antelopejs-interface-core-0.x: @antelopejs/interface-core ^0.4.0 -> ^0.5.0 (minor) automerge=true
renovate/antelopejs-interface-database-0.x: @antelopejs/interface-database 0.4.0 -> 0.4.3 (patch) automerge=true
renovate/antelopejs-modules: @antelopejs/interface-core 0.3.0 -> 0.5.1 (minor) automerge=true
renovate/dotenv-18.x: dotenv 8.2.0 -> 18.0.10 (major) automerge=false
renovate/dotenv-8.x: dotenv 8.2.0 -> 8.6.0 (minor) automerge=true

After:

renovate/antelopejs-interface-core-0.x: @antelopejs/interface-core ^0.4.0 -> ^0.5.0 (minor) automerge=false
renovate/antelopejs-interface-database-0.x: @antelopejs/interface-database 0.4.0 -> 0.4.3 (patch) automerge=true
renovate/antelopejs-modules: @antelopejs/interface-core 0.3.0 -> 0.5.1 (minor) automerge=false
renovate/dotenv-18.x: dotenv 8.2.0 -> 18.0.10 (major) automerge=false
renovate/dotenv-8.x: dotenv 8.2.0 -> 8.6.0 (minor) automerge=true

Checklist

  • The pull request title follows Conventional Commits.
  • I added or updated tests when behavior changed.
  • I updated documentation when users or contributors are affected.
  • I documented breaking changes and migration steps. No breaking change: callers keep every input.
  • I did not include credentials or unrelated changes.

Skills

no skill change

Follow-ups

  • none

…ER_CI, keep 0.x minors manual

Private repositories pay for GitHub-hosted minutes and AntelopeJS has no
Windows runner of its own, so ci-node.yml schedules windows-latest only when
the calling repository is public, in every tier. release-npm.yml runs on the
caller's RUNNER_CI for a private or internal repository; a public one stays
on ubuntu-latest for npm provenance. The Renovate preset no longer
auto-merges a minor update of a 0.x version, which can break.

Task: Wec9b4589-35
@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 23:25
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 0b40536 Nov 20, 2026
4 checks passed
@Upd4ting
Upd4ting deleted the ci/wec9b4589-35-public-only-hosted-runners branch November 20, 2026 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant