Skip to content

test(e2e): drive the undriven flows and run every journey in the merge queue - #151

Merged
Upd4ting merged 14 commits into
mainfrom
test/wdf26acfc-17-e2e-flows
Nov 19, 2026
Merged

Upd4ting merged 14 commits into
mainfrom
test/wdf26acfc-17-e2e-flows

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Why

Wdf26acfc-17: every browser test of dms-api runs in the standard Playwright suite (playwright test -c e2e, through the @antelopejs/dms/e2e kit), the @smoke ones on every pull request and the full suite in the merge queue. Flows the verify feature map listed as Not driven now have journeys, and the command-line checks of the verify harness run as ordinary Vitest tests on every pull request.

Summary

  • New journeys (11) for the Not driven flows of .agents/skills/verify-dms-api/coverage/. Each one is listed in its feature file and in features/README.md, and its coverage row names it. SKILL.md's Not driven list shrinks to match.
  • Vitest integration tests (tests/package.test.ts, with tests/helpers/package.ts). They run the checks of the command-line package journeys (npm pack, ranges, skill, docs links, locales) and dms-control map. Before this, those checks ran only nightly or in a verify run. semver and @types/semver become devDependencies for the range checks.
  • CI (ci.yml). select outputs e2e:
    • none on a draft.
    • smoke (--grep @smoke) on a pull request or a push.
    • all on merge_group, schedule, workflow_dispatch and a pull request labelled ci:full. It runs two shards plus the merged report, and the ubuntu gate requires the job whenever e2e is not none.
    • The merge_group trigger belongs to the on: block that antelopejs-sync owns. It comes with the move to @antelopejs/tooling-configs >=0.8.9 <0.9.0 (root and frontend-vue). That sync also moves the push trigger and the release workflow to main, removes next-sync.yml and stale.yml, and turns on affected-tests.
  • @smoke. The 7 existing tags stay: one per feature, with smoke first in the feature map. The new journeys carry none.

Feature-map flows and the spec that covers each

New journeys, all in the Playwright suite:

Feature Flow (was Not driven) Journey File
logs / opens the search, ? lists the shortcuts slash-opens-the-request-search-and-question-mark-lists-the-shortcuts e2e/journeys/logs/keyboard-and-drawer.mjs
logs Copy cURL copies the open request copy-curl-copies-the-open-request-as-a-command same
logs Dragging the drawer's edge widens it, kept after a reload dragging-the-drawers-left-edge-widens-it-and-it-opens-again-at-that-width same
logs "Table on hold" while a row is open or a search is active an-open-row-or-an-active-search-holds-the-table-and-says-why (one knownFailures entry, below) same
overview L toggles Live and Pause l-switches-the-page-between-live-and-pause e2e/journeys/overview/live-shortcut.mjs
routes / opens the route filter slash-opens-the-route-filter e2e/journeys/routes/keyboard-and-clipboard.mjs
routes Copy cURL copies an example call copy-curl-on-a-route-copies-an-example-call same
settings The Use default button removes an override the-use-default-button-removes-an-override-on-the-page e2e/journeys/settings.mjs
access A member is kept out of the module's pages a-member-without-the-modules-permissions-is-sent-to-their-settings e2e/journeys/access.mjs
access A panel reads only a request its table can list a-panel-opened-from-one-table-reads-only-a-request-that-table-can-list same
tester The forwarding route refuses unsafe paths and drops blocked headers the-forwarding-route-refuses-unsafe-paths-and-never-forwards-blocked-headers e2e/journeys/tester/forwarding.mjs

The other flows of the feature map were already covered and keep their journeys unchanged: smoke, capture, overview, logs, routes, tester, settings, retention, access and package (e2e/journeys/<feature>.mjs, listed per feature in .agents/skills/verify-dms-api/features/README.md).

Still not driven, with the reasons in coverage/: the automation runtime's election, a second backend sharing testerSourceSecret, the Tester's own Copy cURL and editors, the 30 s forwarding timeout, and the Copy buttons beside a value.

Non-browser checks and the tests that run them

Check run by the verify harness or dms-control Integration test (tests/package.test.ts)
package journey the-tarball-holds-what-the-manifest-names (npm pack --dry-run) the packed tarball › holds the built entry…, › holds nothing outside dist…
package journey the-ranges-and-the-skill-match-what-the-docs-name the ranges the docs name › … (3), the skill › … (2)
package journey the-docs-links-and-the-two-locales-are-complete the docs and the locales › … (2)
dms-control map the verify feature map › covers every user-facing file…
dms-control formal (TLC) Unchanged: CI's formal-route-statistics job already runs it on every pull request

The HTTP-only journeys (access, capture, overview verdicts, automation, and the new tester and access ones) stay in the Playwright suite. They need the DMS backend, MongoDB and auth that the kit's run starts, and the Vitest suite has no backend. The package journeys also stay, as the brief keeps every journey.

Proof

Playwright test counts, TZ=UTC pnpm exec playwright test -c e2e --list | tail -1:

All --grep @smoke
Before (main, 5b2dc87) Total: 74 tests in 1 file Total: 7 tests in 1 file
After Total: 85 tests in 1 file Total: 7 tests in 1 file
  • Local: each new journey passed in DMS_E2E_PREBUILT=1 TZ=UTC pnpm e2e -g "<ids>", and the three keyboard journeys passed twice more after a race fix. pnpm exec vitest run tests/package.test.ts gives Tests 10 passed (10).
  • The map test has teeth. A tracked src/zz/probe.ts makes dms-control map print unmapped: src/zz/probe.ts matches no feature glob and exit 1. A feature naming an undescribed journey makes it exit 1 too.
  • CI, a manual run of every journey on this branch before the new journeys (74 tests): https://github.com/AntelopeJS/dms-api/actions/runs/44451538885. e2e (1) and e2e (2) passed, about 7 min each. Its one failure, sync:check on the merge_group trigger, is fixed in 68ff39c.
  • CI, a manual run of every journey with the new ones (85 tests): https://github.com/AntelopeJS/dms-api/actions/runs/44453973559. e2e (1) passed in 6.5 min and e2e (2) in 8.5 min, and so did e2e-report. Its one failure, size (e2e/journeys/tester.mjs 1,364 bytes over 20,000), is fixed by moving the forwarding journey to e2e/journeys/tester/forwarding.mjs, which passed again locally.
flowchart LR
  E[event] --> S{select}
  S -->|draft| N[e2e skipped]
  S -->|pull_request, push| SM["pnpm e2e --grep @smoke"]
  S -->|merge_group, schedule, workflow_dispatch, ci:full label| A["pnpm e2e --shard=i/2 + merged report"]
Loading

Known failure

an-open-row-or-an-active-search-holds-the-table-and-says-why lists an open request says the table is on hold, row open in knownFailures. The request panel is a modal drawer target, and the DMS names the row open hold only for a docked sidePanel target. An open request does hold the table, behind the 1 new request · Show pill, but never says why. docs/4.usage/1.overview.md (Live mode) promises the notice.

Follow-ups

  • proposed AntelopeJS/dms: a table whose row panel is a drawer target holds its rows silently while a row is open, done means it shows Table on hold · row open as a sidePanel target does, and the dms-api journey's knownFailures entry reads fixed

@Upd4ting
Upd4ting marked this pull request as ready for review November 19, 2026 03:59
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 253b371 Nov 19, 2026
13 checks passed
@Upd4ting
Upd4ting deleted the test/wdf26acfc-17-e2e-flows branch November 19, 2026 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant