Skip to content

chore: delete the verify-dms-api harness - #154

Merged
Upd4ting merged 3 commits into
mainfrom
chore/wdf26acfc-103-delete-verify-harness
Nov 19, 2026
Merged

Upd4ting merged 3 commits into
mainfrom
chore/wdf26acfc-103-delete-verify-harness

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Task Wdf26acfc-103, second PR, after #153.

⚠ sensitive: deletes about 1000 non-test lines, almost all the verify skill's Markdown; no auth, schema, contract or published file changes

Why

Decision 13 deletes dms-control and the verify harness. #153 moved everything the tests and the e2e kit read out of .agents/skills/verify-dms-api. This PR deletes the harness and every reference to it left in the repo.

Summary

  • .agents/skills/verify-dms-api and its .claude/skills/verify-dms-api link are deleted.
  • AGENTS.md is regenerated by pnpm sync, which drops the line linking the verification skill. Its e2e line now says how to narrow the journeys (--grep @smoke or --grep <journey id>) instead of pointing at the skill.
  • .gitignore drops the rule that kept the skill's coverage folder tracked. formal-route-statistics/SKILL.md drops the sentence on dms-control formal.
  • e2e/journeys/{automation,capture,package}.mjs are deleted. Their journeys run under Vitest since test: port the dms-api inventory journeys off dms-control #152. The empty modules only existed for dms-control map.
  • The fixture names the harness left are renamed: the playground's /verify-api routes become /fixture-api, the verify-agent/1.0 user agent becomes fixture-agent/1.0, the playground is named dms-api-e2e, and VerifyMembersController becomes FixtureMembersController. Comments and the stand-in's errors call it the e2e playground.
  • No devDependency or bin is removed. dms-control is a bin of @antelopejs/dms, which this repo keeps for the e2e kit and pnpm test:frontend. No script and no CI step runs it. e2eConfig() sets no legacy skill option.
flowchart LR
  K[e2e kit] -->|reads| C[e2e/journeys.config.ts] --> P[e2e/playground]
  J[test:journeys] --> P
  T[package.test.ts] -->|imports| E[e2e/journeys/*.mjs]
  X[.agents/skills/verify-dms-api]:::gone
  classDef gone stroke-dasharray: 5 5
Loading

Proof

The run used b175e4c, with the folders deleted and no dms-control on PATH:

$ ls .agents/skills .claude/skills
.agents/skills:
formal-route-statistics
technical-writing
unslop

.claude/skills:
technical-writing
unslop
$ command -v dms-control || echo none
none
$ pnpm run checks
Checks: 11 passed, 0 failed.
$ pnpm exec vitest run --maxWorkers 4
 Test Files  35 passed (35)
      Tests  351 passed (351)
$ pnpm e2e:build
exit 0
$ TZ=UTC pnpm test:journeys
 Test Files  10 passed (10)
      Tests  31 passed (31)
$ TZ=UTC pnpm e2e --grep @smoke --workers 1
  7 passed (3.9m)

git grep -n "verify-\|dms-control" outside CHANGELOG.md finds only:

.agents/skills/formal-route-statistics/SKILL.md:99  history: the branch `feat/verify-dms-api-skill` the model was synced on
.github/workflows/ci.yml:174-176                    ~/.cache/dms-control/frontend: the e2e kit's frontend build cache, a path the kit hard-codes
AGENTS.md:23, README.md:102, docs/design/redesign-grill-me.md:406, package.json:43
                                                    `ajs dms verify-source`: the `ajs` CLI command that typechecks the Vue layer

Follow-ups

  • proposed AntelopeJS/dms: the e2e kit still names its frontend build cache ~/.cache/dms-control/frontend and its run folder variable DMS_CONTROL_RUNS after the CLI decision 13 deletes, done means the kit uses names without dms-control and repositories cache that path instead

@Upd4ting
Upd4ting marked this pull request as ready for review November 19, 2026 12:49
@Upd4ting
Upd4ting enabled auto-merge November 19, 2026 12:56
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 608eafb Nov 19, 2026
22 of 26 checks passed
@Upd4ting
Upd4ting deleted the chore/wdf26acfc-103-delete-verify-harness branch November 19, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant