Repository navigation
chore: delete the verify-dms-api harness - #154
Merged
Merged
Conversation
Upd4ting
marked this pull request as ready for review
November 19, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Wdf26acfc-103, second PR, after #153.
⚠ sensitive: deletes about 1000 non-test lines, almost all the verify skill's Markdown; no auth, schema, contract or published file changes
Why
Decision 13 deletes
dms-controland the verify harness. #153 moved everything the tests and the e2e kit read out of.agents/skills/verify-dms-api. This PR deletes the harness and every reference to it left in the repo.Summary
.agents/skills/verify-dms-apiand its.claude/skills/verify-dms-apilink are deleted.AGENTS.mdis regenerated bypnpm sync, which drops the line linking the verification skill. Its e2e line now says how to narrow the journeys (--grep @smokeor--grep <journey id>) instead of pointing at the skill..gitignoredrops the rule that kept the skill'scoveragefolder tracked.formal-route-statistics/SKILL.mddrops the sentence ondms-control formal.e2e/journeys/{automation,capture,package}.mjsare deleted. Their journeys run under Vitest since test: port the dms-api inventory journeys off dms-control #152. The empty modules only existed fordms-control map./verify-apiroutes become/fixture-api, theverify-agent/1.0user agent becomesfixture-agent/1.0, the playground is nameddms-api-e2e, andVerifyMembersControllerbecomesFixtureMembersController. Comments and the stand-in's errors call it the e2e playground.dms-controlis a bin of@antelopejs/dms, which this repo keeps for the e2e kit andpnpm test:frontend. No script and no CI step runs it.e2eConfig()sets no legacyskilloption.Proof
The run used
b175e4c, with the folders deleted and nodms-controlon PATH:git grep -n "verify-\|dms-control"outsideCHANGELOG.mdfinds only:Follow-ups
~/.cache/dms-control/frontendand its run folder variableDMS_CONTROL_RUNSafter the CLI decision 13 deletes, done means the kit uses names withoutdms-controland repositories cache that path instead