Repository navigation
fix(settings): cap the stored body capture limit at the config value - #156
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: W05057e83-19
Summary
A body capture limit saved from the settings page overrode
antelope.config.ts, so it could raise the limit above what the operator set. The config value is now a ceiling: the storedrequestLogMaxBodySizeis capped to it (src/services/settings.ts).Proof
tests/settings-ceiling.test.ts"is capped to the body capture limit of the config" fails:expected 1000000 to be 1000.flowchart LR A[stored requestLogMaxBodySize] --> B{above config value?} B -- yes --> C[config value] B -- no --> D[stored value]Follow-ups