Repository navigation
test: accept a 3 or 4 minute count in the monitor hero journey - #157
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wec9b4589-29: the nightly
e2e (2)job failed once (run 44660365482, 2026-11-20) on the monitor hero journey.Summary
The journey seeds the incident 3 minutes back, then asserts
for 3 min. When seeding and page load take long enough the hero readsfor 4 min. The assertion is nowfor [34] min. The existing API check (durationMsbetween 150s and 240s) already allowed that range.Proof
Before, in run 44660365482:
Error: page shows /for 3 min\s*·\s*checked \d\d:\d\d:\d\d/: ....After: manual
workflow_dispatchrun, all jobs green includinge2e (1)ande2e (2): https://github.com/AntelopeJS/dms-api/actions/runs/44826308331 (a manual run cannot reach the nightly tier; the next scheduled nightly is the final proof).flowchart LR A[seed incident 3 min ago] --> B[sign in, load hero] B --> C{elapsed} C -->|3 min| D[Down for 3 min] C -->|4 min| E[Down for 4 min] D --> F[matches for 3 or 4 min] E --> FFollow-ups