Skip to content

test: accept a 3 or 4 minute count in the monitor hero journey - #157

Merged
Upd4ting merged 1 commit into
mainfrom
test/wec9b4589-29-monitor-wall-clock
Nov 20, 2026
Merged

Upd4ting merged 1 commit into
mainfrom
test/wec9b4589-29-monitor-wall-clock

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Wec9b4589-29: the nightly e2e (2) job failed once (run 44660365482, 2026-11-20) on the monitor hero journey.

Summary

The journey seeds the incident 3 minutes back, then asserts for 3 min. When seeding and page load take long enough the hero reads for 4 min. The assertion is now for [34] min. The existing API check (durationMs between 150s and 240s) already allowed that range.

Proof

Before, in run 44660365482: Error: page shows /for 3 min\s*·\s*checked \d\d:\d\d:\d\d/: ....
After: manual workflow_dispatch run, all jobs green including e2e (1) and e2e (2): https://github.com/AntelopeJS/dms-api/actions/runs/44826308331 (a manual run cannot reach the nightly tier; the next scheduled nightly is the final proof).

flowchart LR
  A[seed incident 3 min ago] --> B[sign in, load hero]
  B --> C{elapsed}
  C -->|3 min| D[Down for 3 min]
  C -->|4 min| E[Down for 4 min]
  D --> F[matches for 3 or 4 min]
  E --> F
Loading

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 22:16
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 5015789 Nov 20, 2026
38 checks passed
@Upd4ting
Upd4ting deleted the test/wec9b4589-29-monitor-wall-clock branch November 20, 2026 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant