Skip to content

fix: scope the assistant status's last error to the signed-in owner - #130

Merged
Upd4ting merged 1 commit into
mainfrom
fix/wffd6e624-32-owner-last-error
Nov 20, 2026
Merged

Upd4ting merged 1 commit into
mainfrom
fix/wffd6e624-32-owner-last-error

Conversation

@Upd4ting

Copy link
Copy Markdown
Member

Summary

Task Wffd6e624-32, follow-up of ANT-3486 (#125). lastError in /ai/status and its banner was one global value, so one owner's failed turn showed on another owner's banner. The sidecar now records the error per conversation and reports the newest one among the conversations the viewer may see, the same set #125 uses for the counts. A request naming nobody sees none.

⚠ sensitive: changes what one owner sees of another owner's activity (status and banner)

Proof

Test shows a failed turn only to the person whose conversation failed in sidecar/tests/integration/status-matches-list.test.ts.

Before (source reverted): × ... shows a failed turn only to the person whose conversation failed (1 failed, 2 passed).
After: Tests 3 passed (3); full sidecar suite 1259 passed | 10 skipped.

flowchart LR
  E[turn error] --> R[turns.recordError conversationId, message]
  S[GET /status?viewer] --> V[viewerActivity: visible conversations]
  V --> L[turns.lastError visible ids -> newest]
  R --> L
Loading

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 12:56
@Upd4ting
Upd4ting enabled auto-merge November 20, 2026 12:56
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 42b28f7 Nov 20, 2026
25 of 40 checks passed
@Upd4ting
Upd4ting deleted the fix/wffd6e624-32-owner-last-error branch November 20, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant