Repository navigation
fix(ci): run the formal checks and two sidecar tests on Windows - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Task Wec9b4589-21, from ANT-3515. The nightly
cirun has failed on Windows since 2026-11-16, in two jobs:ci / Test .nvmrc on Windows: the five.agents/skills/formal-*/check.mjsscripts calledspawnSync("pnpm", [...])without a shell. On Windows pnpm ispnpm.cmd, so every check exited 2 withcheck: cannot run pnpm: spawnSync pnpm ENOENT. Each script now passes one command string withshell: true. That resolvespnpm.cmdon Windows and avoids Node 24's DEP0190 warning, whichshell: truewith an args array prints. The arguments are constants with no spaces or shell metacharacters.vitest (windows-latest, sidecar):tests/unit/tool-guard.test.tsandtests/unit/session-tool-results-read.test.tspassed drive-less roots (/work/app) to the read guard. The guard resolves every target, so on Windows the target becameD:\work\app\...and never matched the root. The code is right: production roots come fromresolveReadRoots, which resolves them, and the CLI sends transcript paths that include a drive. The fixtures now useresolve(), astests/unit/read-access.test.tsalready does.Proof
Before (nightly run 44660523547):
After, locally on Linux (Node 24):
A manual run cannot reach the nightly tier (the shared
ci-tieraction returnsnightlyonly forschedule), so the next scheduled nightly is the Windows proof. An extra Windows run, from a throwaway branch that turns the Windows legs on for manual runs and is not merged: run 44826523943.flowchart LR C[formal-*/check.mjs] -->|"before: spawnSync('pnpm', args)"| X[ENOENT on Windows] C -->|"after: spawnSync('pnpm ...', shell: true)"| S[cmd.exe resolves pnpm.cmd] --> V[vitest spec]Follow-ups
@antelopejs/dmsand@antelopejs/interface-dmspreview pair: the playground builds failed onmainbecause of the mismatch, which brokee2eandintegrationhere.