Skip to content

fix(ci): run the formal checks and two sidecar tests on Windows - #131

Merged
Upd4ting merged 1 commit into
mainfrom
fix/wec9b4589-21-nightly-windows
Nov 20, 2026
Merged

Upd4ting merged 1 commit into
mainfrom
fix/wec9b4589-21-nightly-windows

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

Task Wec9b4589-21, from ANT-3515. The nightly ci run has failed on Windows since 2026-11-16, in two jobs:

  • ci / Test .nvmrc on Windows: the five .agents/skills/formal-*/check.mjs scripts called spawnSync("pnpm", [...]) without a shell. On Windows pnpm is pnpm.cmd, so every check exited 2 with check: cannot run pnpm: spawnSync pnpm ENOENT. Each script now passes one command string with shell: true. That resolves pnpm.cmd on Windows and avoids Node 24's DEP0190 warning, which shell: true with an args array prints. The arguments are constants with no spaces or shell metacharacters.
  • vitest (windows-latest, sidecar): tests/unit/tool-guard.test.ts and tests/unit/session-tool-results-read.test.ts passed drive-less roots (/work/app) to the read guard. The guard resolves every target, so on Windows the target became D:\work\app\... and never matched the root. The code is right: production roots come from resolveReadRoots, which resolves them, and the CLI sends transcript paths that include a drive. The fixtures now use resolve(), as tests/unit/read-access.test.ts already does.

Proof

Before (nightly run 44660523547):

ci / Test .nvmrc on Windows
  AssertionError [ERR_ASSERTION]: check: cannot run pnpm: spawnSync pnpm ENOENT   (x5)

vitest (windows-latest, sidecar)
  FAIL tests/unit/session-tool-results-read.test.ts > reading a saved tool result > auto-allows reads in the current session's folder once the hook has run
    expected false to be true
  FAIL tests/unit/tool-guard.test.ts > the PreToolUse guard in Plan only > leaves edits, reads, sub-agents, questions and scheduling to the CLI
    Read / Glob / Grep: expected "none", received "ask"

After, locally on Linux (Node 24):

$ node --test --test-reporter=tap tests/formal-*.test.cjs
# pass 5
# fail 0
$ pnpm --dir sidecar exec vitest run tests/unit/tool-guard.test.ts tests/unit/session-tool-results-read.test.ts
 Test Files  2 passed (2)
      Tests  44 passed (44)

A manual run cannot reach the nightly tier (the shared ci-tier action returns nightly only for schedule), so the next scheduled nightly is the Windows proof. An extra Windows run, from a throwaway branch that turns the Windows legs on for manual runs and is not merged: run 44826523943.

flowchart LR
  C[formal-*/check.mjs] -->|"before: spawnSync('pnpm', args)"| X[ENOENT on Windows]
  C -->|"after: spawnSync('pnpm ...', shell: true)"| S[cmd.exe resolves pnpm.cmd] --> V[vitest spec]
Loading

Follow-ups

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 22:12
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 7e685ee Nov 20, 2026
36 of 44 checks passed
@Upd4ting
Upd4ting deleted the fix/wec9b4589-21-nightly-windows branch November 20, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant