Repository navigation
test: port the inventory's HTTP journeys to integration tests - #218
Merged
Merged
Conversation
The layout, notes, note refusals and owner-only journeys of the Diagram feature run in src/test/diagram.journeys.test.ts through HTTP, and leave the Playwright suite.
The source, filters, instance counts, instances, single table, column inference and owner-only journeys run in src/test/schemas.journeys.test.ts on schemas the test registers, and leave the Playwright suite.
The introspection and table-watch journeys run in src/test/extending.journeys.test.ts, the table watch through a procedure of the dms-automation module the harness loads. The playground no longer loads dms-automation on a flag, which only the table-watch journey set. The silent no-op without dms-automation stays a journey: the harness always loads the module.
The library-survives-a-restart journey runs in src/test/library.journeys.test.ts: the harness cannot restart its backend, so the test reads the run and the shared saved query from the module's own tables through a MongoDB client of its own, then through the routes.
every-route-needs-a-signed-in-session, a-member-gets-403-from-every-route-and-writes-nothing and the-owner-only-gate-is-logged-at-start leave the Playwright suite for src/test/access.journeys.test.ts. The owner-only gate is checked on each page's layout route, which the start log reports on. the-catalog-tile-reads-the-database takes the @smoke tag.
built-in-patterns-label-schemas-by-the-start-of-their-id, an-exact-key-beats-a-pattern-which-beats-a-built-in-label and a-glob-key-matches-the-whole-schema-id leave the Playwright suite for src/test/config.journeys.test.ts. The harness sets schemaLabels whose keys match only that file's schemas, so each resolution rule is read over HTTP without a restart; the built-in journey removes the option for its run.
The seven browse API journeys leave the Playwright suite for src/test/data.journeys.test.ts and src/test/data-reads.journeys.test.ts, split to stay under the lint's line caps, over a copy of the playground's shop, metrics and demo data seeded by src/test/dataJourneys.ts. The column-order check e2e carried as a known failure passes on @antelopejs/mongodb 1.8.11.
the-edit-route-writes-typed-values-and-refuses-the-rest leaves the Playwright suite for src/test/editing.journeys.test.ts.
…nventory # Conflicts: # .agents/skills/verify-dms-database/features/README.md
Upd4ting
marked this pull request as ready for review
November 19, 2026 09:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Wdf26acfc-86. Decision 13 of the trunk run deletes
dms-controland the DMS verify harness once every line they run has a home. AntelopeJS/dmse2e/INVENTORY.mdlists 154 lines for dms-database, and 37 of them weretodo. This pull request moves each one to its destination, so the orchestrator can mark the whole dms-database section done. HTTP journeys become integration tests ofpnpm test. Browser journeys and the prepare step stay in the repo's own Playwright suite, which runs with nodms-control.dms-database keeps its own Playwright stack rather than moving onto the
@antelopejs/dms/e2ekit. The orchestrator settled this in the task thread: the inventory names the repo'se2e/as the browser destination, and the kit at0.21.4-next.939still loads journeys through.agents/skills/verify-*/verify.config.ts, the folder the final step deletes.What changed
pnpm test. Each is now anittitled with its journey id, insrc/test/<feature>.journeys.test.ts. The data journeys are split intodata.journeys.test.tsanddata-reads.journeys.test.ts, under the 500-line cap. Each file builds the schemas and rows it needs, then calls the routes over HTTP as an owner, a member or nobody (src/test/helpers/http.ts). The Playwright copies are deleted, so nothing runs twice. Playwright now lists 126 tests, down from 154.the-owner-only-gate-is-logged-at-start) now checks the gate that log line reports. The layout route of each of the five pages answers the owner 200 and a member with the module's permissions 403.schemaLabels) read every resolution rule over HTTP from one harness config whose keys match only that file's schemas. Before, the backend restarted with a new config for each case.the-library-survives-a-backend-restart) reads the run and the shared saved query straight from the module's own MongoDB tables with a separate client, then through the routes. It fails if the library lives only in backend memory.without-the-automation-module-the-trigger-registration-is-a-silent-no-opneeds a backend without@antelopejs/dms-automation. The integration harness always loads that module, which the table-watch test needs. The row's destination changes to Playwright.@smoke.access › the-catalog-tile-reads-the-databasetakes its tag, so--grep @smokestill runs 5 journeys.src/test/package.test.ts, which test(e2e): cover the verify skill's undriven flows and run the suite in the merge queue #217 added. The browser rows 19, 75, 86 and 87 failed in the 2026-11-19 nightly and passed in test(e2e): cover the verify skill's undriven flows and run the suite in the merge queue #217's merge-queue run (44477715725, 154 passed). Row 154's four prepare commands are the CI install,pnpm e2e:buildand the committede2e/playground/node_moduleslink.VERIFY_DATABASE_AUTOMATION, which only the moved table-watch journey set. The verify skill's feature files name each moved id with its test file.src/test/feature-map.test.tsstill passes.Proof
Mutation check, run on this branch. Compiling a
schemaLabelsglob without its$anchor (src/service/schemaLabels.ts:23) fails the two config journeys. Restoring it passes all three:The porting agents also ran mutation checks. Raising the list route's 200-row cap fails row 11. Dropping the layout write from the diagram route fails row 32.
Counts.
playwright test -c e2e --list--grep @smokepnpm testflowchart LR subgraph before PW1[Playwright e2e: 154 journeys, own stack] --> HTTP1[28 HTTP journeys] end subgraph after PW2[Playwright e2e: 126 browser journeys + row 84] T[pnpm test: ajs harness, in-memory MongoDB] --> J[9 *.journeys.test.ts files, 28 tests] end HTTP1 -- moved --> JInventory lines (dms-database section)
Lines per status. Before: 117
green in CI, 37todo. After: 154green in CI, 0deleted: duplicate, 0todo.every-route-needs-a-signed-in-sessionsrc/test/access.journeys.test.ts, was @smokea-member-gets-403-from-every-route-and-writes-nothingsrc/test/access.journeys.test.tsa-member-sees-neither-the-pages-nor-the-catalog-tilethe-catalog-tile-reads-the-databasethe-owner-only-gate-is-logged-at-startsrc/test/access.journeys.test.tsbuilt-in-patterns-label-schemas-by-the-start-of-their-idsrc/test/config.journeys.test.tsan-exact-key-beats-a-pattern-which-beats-a-built-in-labelsrc/test/config.journeys.test.tsa-glob-key-matches-the-whole-schema-idsrc/test/config.journeys.test.tsa-label-takes-each-of-the-seven-tonesthe-instance-picker-lists-named-instances-with-a-search-and-a-limitsrc/test/data.journeys.test.tslist-clamps-the-page-and-orders-the-rowssrc/test/data.journeys.test.tslist-filters-search-and-counts-follow-the-wire-tokenssrc/test/data.journeys.test.tsthe-selection-decodes-schema-table-and-instancesrc/test/data-reads.journeys.test.tscolumns-get-and-tables-answer-what-the-grid-needssrc/test/data-reads.journeys.test.tsreferences-count-the-rows-pointing-at-a-rowsrc/test/data-reads.journeys.test.tsthe-browse-api-answers-the-platform-owner-onlysrc/test/data.journeys.test.tsthe-sidebar-counts-each-table-in-the-picked-instancetables-open-as-preview-tabs-and-are-kept-on-demandsearch-filters-and-sort-narrow-and-order-the-rowsthe-footer-pages-1250-rows-with-exact-ranges-at-every-sizethe-row-drawer-steps-through-the-page-with-j-and-kthe-row-drawer-shows-fields-json-and-the-rows-pointing-at-itthe-fields-tab-widens-long-values-and-sets-null-with-the-dashed-circlelinks-open-the-table-in-the-instance-they-nameall-instances-is-a-read-only-view-with-the-instance-columnrecently-opened-tables-are-offered-when-no-tab-is-openno-match-and-empty-tables-say-soa-refused-read-shows-the-error-and-try-again-reads-it-againr-refreshes-the-rows-and-the-search-shortcut-works-from-the-gridrows-per-page-offers-exactly-25-50-100-and-200a-filter-is-either-contains-or-is-exactly-in-the-dialog-and-in-a-column-funnelthe-layout-api-stores-one-layout-per-schema-and-refuses-bad-positionssrc/test/diagram.journeys.test.tsthe-notes-api-creates-lists-updates-and-deletes-notes-per-schemasrc/test/diagram.journeys.test.tsthe-notes-api-refuses-missing-numbers-with-400-and-unknown-notes-with-404src/test/diagram.journeys.test.tsevery-diagram-route-answers-the-platform-owner-onlysrc/test/diagram.journeys.test.tstables-list-their-columns-with-types-and-icons-and-relations-are-arrowsan-encrypted-column-carries-the-lock-icon-of-the-legenda-table-of-more-than-twelve-columns-comes-folded-and-folding-is-not-savedthe-fold-keeps-the-twelve-column-boundary-and-every-column-an-arrow-ends-onfolding-is-a-setting-of-your-own-view-and-is-not-saved-with-the-team-layoutfinding-a-column-a-folded-table-hides-unfolds-that-tablea-large-schema-opens-at-forty-percent-on-its-top-left-and-fit-view-shows-it-wholea-relation-to-a-table-not-drawn-ends-on-a-dashed-chip-that-opens-that-tablea-relation-to-another-schema-ends-on-a-chip-that-opens-that-tablethe-url-picks-the-schema-and-the-table-and-names-what-it-cannot-finda-schema-without-a-table-says-so-and-offers-no-note-or-auto-layoutdragging-a-table-saves-the-layout-and-everyone-reads-ita-table-not-placed-yet-takes-its-automatic-place-and-placed-tables-stayauto-layout-previews-the-arrangement-and-keep-or-discard-decidesauto-layout-and-note-wait-until-the-picked-schema-has-loadedauto-layout-keeps-groups-together-and-clear-of-notes-that-never-moven-and-the-note-button-drop-a-note-ready-to-write-and-it-is-saved-with-the-schemaa-double-click-edits-a-note-and-the-trash-button-and-delete-remove-itnotes-belong-to-their-schema-and-everyone-reads-themundo-and-redo-cover-every-move-and-note-and-are-savedeach-relation-arrow-starts-at-its-own-columnescape-steps-back-from-a-selected-tablea-double-click-opens-the-inspector-and-a-relation-opens-the-other-table-in-itf-focuses-the-find-field-but-not-while-writing-a-noteh-pans-the-canvas-and-v-selects-againfit-view-keeps-every-table-inside-the-canvasthe-shortcuts-settings-page-lists-the-diagram-shortcutsthe-layout-and-the-notes-survive-a-backend-restartedits-are-staged-then-reviewed-then-written-one-put-per-rowinvalid-drafts-are-refused-esc-cancels-and-a-click-away-decidesnull-empties-a-cell-and-backslash-null-is-the-text-nullobject-and-array-cells-open-the-json-editor-in-a-side-drawerthe-json-editor-is-as-tall-as-the-drawerdiscard-and-closing-a-tab-with-staged-changes-ask-firstundo-writes-the-previous-values-back-within-the-windowundo-is-offered-for-ten-seconds-then-the-values-staya-row-deleted-meanwhile-drops-its-changes-and-the-rest-is-saveda-failed-write-stops-the-save-and-the-rows-left-stay-stageda-saved-row-shows-in-place-unless-the-save-may-move-rowsa-save-under-a-search-or-a-filter-reads-the-page-againan-edit-and-its-undo-land-in-the-instance-of-the-tab-onlysaved-cells-keep-their-type-numbers-booleans-dates-and-objectsthe-edit-route-writes-typed-values-and-refuses-the-restsrc/test/editing.journeys.test.tshashed-encrypted-and-localized-columns-are-written-as-typedthe-row-drawer-stages-edits-like-the-cells-dodiscard-drops-the-changes-of-every-staged-rowa-registered-schema-shows-its-tables-columns-indexes-relations-and-modifierssrc/test/extending.journeys.test.tsdeep-links-open-the-documented-pages-on-the-tablewithout-the-automation-module-the-trigger-registration-is-a-silent-no-opthe-table-watch-hands-a-procedure-each-insert-update-and-deletesrc/test/extending.journeys.test.tsan-external-database-is-picked-browsed-edited-and-leftan-external-database-refuses-what-it-cannot-serve-with-sentencesa-delete-names-its-operation-target-and-rows-and-waits-for-the-table-nameevery-write-names-its-operation-and-counts-the-rows-it-would-touchconfirming-a-single-row-update-needs-the-table-name-as-the-docs-saya-replace-names-its-operation-and-rows-and-waits-for-the-table-namea-replace-on-a-selection-changes-every-row-the-dry-run-announceda-confirmed-write-acts-on-the-data-of-that-momenta-read-query-runs-straight-awayhistory-keeps-your-last-500-runs-newest-firsthistory-records-failures-and-writes-with-their-statushistory-is-searchable-and-clearing-it-keeps-the-saved-queriesclear-history-empties-only-your-own-runsa-saved-query-needs-a-name-and-can-be-edited-and-deleteda-shared-query-reaches-the-team-and-only-its-author-changes-ithistory-belongs-to-its-user-and-a-link-restores-a-runthe-library-survives-a-backend-restartsrc/test/library.journeys.test.tsthe-connection-card-reads-the-probea-configured-driver-label-shows-beside-the-agewithout-a-driver-label-the-card-shows-a-dashthe-card-age-counts-up-and-the-probe-repeats-every-thirty-secondsschema-cards-list-every-schema-largest-firstlargest-tables-rank-the-default-instances-by-rowsrecent-queries-list-your-last-five-runsthe-header-buttons-lead-to-the-working-pagesthe-tarball-holds-what-its-manifest-namessrc/test/package.test.tsboth-locales-hold-the-same-textssrc/test/package.test.tsranges-match-the-compatibility-tablesrc/test/package.test.tsa-query-returns-its-rows-in-the-order-it-asksan-instance-and-every-instance-are-targeteda-failed-query-says-what-failed-and-offers-the-nearest-namethe-insert-chips-add-their-operationctrl-space-completes-schemas-and-tables-from-the-workspacean-empty-console-offers-examples-built-on-your-own-tablesresults-over-1000-rows-are-cut-at-1000the-table-view-shows-every-returned-rowan-export-of-uneven-rows-keeps-every-key-in-csv-and-jsoncsv-quotes-a-comma-a-quote-and-a-line-break-so-the-cell-reads-backformat-strips-trailing-spaces-and-blank-linesctrl-space-inside-a-filter-completes-the-columns-of-the-tablethe-chart-plots-the-first-numeric-column-with-pickers-for-both-axesopen-in-data-browser-opens-the-target-table-or-the-rowcopy-as-json-puts-the-returned-rows-on-the-clipboardthe-source-counts-rows-columns-indexes-relations-and-modifiers-of-each-tablesrc/test/schemas.journeys.test.tsschema-instance-search-and-structure-filters-narrow-the-source-and-combinesrc/test/schemas.journeys.test.tsrows-are-counted-in-the-picked-instance-default-named-or-allsrc/test/schemas.journeys.test.tsthe-instances-route-searches-sorts-and-limits-the-named-instances-of-a-schemasrc/test/schemas.journeys.test.tsa-table-is-read-by-its-schema-and-name-idsrc/test/schemas.journeys.test.tscolumns-are-declared-in-code-and-inferred-from-sampled-rowssrc/test/schemas.journeys.test.tsthe-tables-and-schemas-routes-answer-the-platform-owner-onlysrc/test/schemas.journeys.test.tseach-filter-of-the-bar-narrows-the-list-and-sets-its-own-url-keythe-url-restores-every-filter-after-a-reload-and-clear-removes-themslash-focuses-the-search-field-but-not-while-typing-or-with-a-modifiera-filter-that-matches-nothing-says-no-result-and-clear-filters-restores-the-listeach-of-the-five-sortable-columns-sorts-both-ways-and-the-third-click-restores-the-default-orderthe-relations-and-modifiers-columns-name-the-tables-and-the-flagsa-row-click-opens-the-inspector-and-previous-next-j-and-k-step-through-the-listdragging-the-drawer-edge-resizes-it-and-it-opens-at-the-width-you-left-itthe-inspector-states-the-counts-and-lists-each-column-with-its-type-null-and-notesa-column-named-constructor-is-listed-like-any-other-columnthe-indexes-and-relations-tabs-list-what-the-table-declares-and-a-relation-opens-the-other-tablethe-sample-row-tab-shows-one-row-and-another-row-pages-through-the-tablebrowse-query-and-diagram-actions-open-the-other-pages-on-the-same-tablewith-modifiers-keeps-a-table-with-only-a-hashed-only-a-localized-or-only-an-encrypted-columna-narrow-inspector-scrolls-its-columns-table-and-its-tabs-sidewayssmokeformal-table-watchformal-access-write-backprepareofverify-dms-database(4 commands)pnpm e2e:build(CIe2ejob)Follow-ups
e2e/INVENTORY.mdrow 84 of dms-database namesintegration src/test/extending.journeys.test.ts, but the line needs a backend without dms-automation. Done means the row reads Playwright as its destination.