Repository navigation
test: read the feature map from e2e instead of the verify skill - #219
Merged
Merged
Conversation
Upd4ting
marked this pull request as ready for review
November 19, 2026 11:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Wdf26acfc-106. Decision 13 deletes
dms-controland the verify harness once the inventory is green. The goal here is that dms-database's CI passes without.agents/skills/verify-dms-databaseand withoutdms-control, so that deletion becomes a plain folder removal.One suite still read that folder at run time.
src/test/feature-map.test.ts(the port ofdms-control map, inpnpm test) readverify.config.tsandfeatures/*.mdfrom the skill. With the folder gone,pnpm testfailed.What changed
e2e/features.jsonholds the feature map: the user-facing globs, the globs left out of them, and each feature'scoversanddocslists. A script generated it from the skill'sverify.config.tsand the frontmatter offeatures/*.md, so the content is unchanged.src/test/feature-map.test.tsreadse2e/features.json. It keeps three checks: every feature has a covers list, every tracked user-facing file is covered, and every docs page exists. The fourth check required each journey id to appear in a skill feature file. It now requires eache2e/journeys/<feature>.mjsto name a feature of the map, because once the skill is gone no feature text is left to name the ids..gitattributesmarkse2e/playground/node_modulesas a directory symlink. The old line named.agents/skills/verify-dms-database/playground/node_modules, which the playground's move toe2e/had already left pointing at nothing.e2e/tab.tsande2e/playground/antelope.config.tsno longer describes behaviour as whatdms-controldid.Not done, and why. No
e2e/journeys.config.tsand no@antelopejs/dmspreview pin. This repo's Playwright suite does not use the@antelopejs/dms/e2ekit. It runs on its own stack (e2e/stack.ts,e2e/fixtures.ts,playwright test -c e2e), which reads neitherverify.config.tsnorjourneys.config.ts. Ajourneys.config.tshere would have no reader, and a prerelease pin would only add risk. Nothing in CI runsdms-control.antelopejs-checkstype-checks a verify layer only when a.agents/skills/verify-*folder exists, so it passes without one.Proof
Each run below had
.agents/skills/verify-dms-databasemoved out of the checkout and nodms-controlon PATH:Before, on
main's test:After, on this branch:
CI's gate command, run in full with the folder moved away:
The one failure is
sync:check.antelopejs-syncwrites the AGENTS.md line that points to the verify skill only while a.agents/skills/verify-*folder exists. Without the folder, it removes this line:-Prove a change works with the verification skill in [`.agents/skills/verify-dms-database/SKILL.md`](.agents/skills/verify-dms-database/SKILL.md) before you call it done.That line is an agent-skill call site, which the brief leaves to the deletion step, so this PR keeps it. The deletion is therefore the folder removal plus
pnpm sync. Here is the same run with that synced AGENTS.md in place, and the folder still moved away:What still references the folder
These are agent-facing docs only, and they go with the skill's deletion:
AGENTS.md:46points to the verification skill'sSKILL.md.antelopejs-syncdrops it once the folder is gone..agents/skills/formal-table-watch/SKILL.mdnames theextendingfeature ofverify-dms-database,dms-control formal, and theformallist ofverify.config.ts.features/README.mdstill saysfeature-map.test.tschecks its files. Itscovers:lists now duplicatee2e/features.jsonuntil the folder is removed.e2e/playgroundkeeps the namesverify-dms-database(inantelope.config.ts) andverify-dms-database-app(inpackage.json). They are project and package names, not paths.Follow-ups