Skip to content

test: read the feature map from e2e instead of the verify skill - #219

Merged
Upd4ting merged 2 commits into
mainfrom
test/wdf26acfc-106-off-verify-harness
Nov 19, 2026
Merged

Upd4ting merged 2 commits into
mainfrom
test/wdf26acfc-106-off-verify-harness

Conversation

@Upd4ting

Copy link
Copy Markdown
Member

Why

Wdf26acfc-106. Decision 13 deletes dms-control and the verify harness once the inventory is green. The goal here is that dms-database's CI passes without .agents/skills/verify-dms-database and without dms-control, so that deletion becomes a plain folder removal.

One suite still read that folder at run time. src/test/feature-map.test.ts (the port of dms-control map, in pnpm test) read verify.config.ts and features/*.md from the skill. With the folder gone, pnpm test failed.

What changed

  • e2e/features.json holds the feature map: the user-facing globs, the globs left out of them, and each feature's covers and docs lists. A script generated it from the skill's verify.config.ts and the frontmatter of features/*.md, so the content is unchanged.
  • src/test/feature-map.test.ts reads e2e/features.json. It keeps three checks: every feature has a covers list, every tracked user-facing file is covered, and every docs page exists. The fourth check required each journey id to appear in a skill feature file. It now requires each e2e/journeys/<feature>.mjs to name a feature of the map, because once the skill is gone no feature text is left to name the ids.
  • .gitattributes marks e2e/playground/node_modules as a directory symlink. The old line named .agents/skills/verify-dms-database/playground/node_modules, which the playground's move to e2e/ had already left pointing at nothing.
  • TSDoc in e2e/tab.ts and e2e/playground/antelope.config.ts no longer describes behaviour as what dms-control did.

Not done, and why. No e2e/journeys.config.ts and no @antelopejs/dms preview pin. This repo's Playwright suite does not use the @antelopejs/dms/e2e kit. It runs on its own stack (e2e/stack.ts, e2e/fixtures.ts, playwright test -c e2e), which reads neither verify.config.ts nor journeys.config.ts. A journeys.config.ts here would have no reader, and a prerelease pin would only add risk. Nothing in CI runs dms-control. antelopejs-checks type-checks a verify layer only when a .agents/skills/verify-* folder exists, so it passes without one.

Proof

Each run below had .agents/skills/verify-dms-database moved out of the checkout and no dms-control on PATH:

$ mv .agents/skills/verify-dms-database $TMPDIR/wdf106/verify-dms-database.away
$ ls .agents/skills
formal-access-write-back  formal-table-watch  technical-writing  unslop
$ command -v dms-control || echo "no dms-control on PATH"
no dms-control on PATH

Before, on main's test:

$ pnpm run build && DMS_PREBUILT=1 pnpm exec ajs module test . -f dist/test/feature-map.test.js
✖ Path not found: …/.agents/skills/verify-dms-database/features
  → Check the path, then try again

After, on this branch:

$ pnpm run build && DMS_PREBUILT=1 pnpm exec ajs module test . -f dist/test/feature-map.test.js
  e2e feature map
    ✔ gives every feature a covers list
    ✔ maps every user-facing file to a feature (58ms)
    ✔ names only docs pages that exist
    ✔ names a feature for every journeys file of the Playwright suite

  4 passing (70ms)

CI's gate command, run in full with the folder moved away:

$ pnpm run checks
[sync:check]
> antelopejs-sync --check
Drift: AGENTS.md; run antelopejs-sync
Checks: 12 passed, 1 failed.

The one failure is sync:check. antelopejs-sync writes the AGENTS.md line that points to the verify skill only while a .agents/skills/verify-* folder exists. Without the folder, it removes this line:

-Prove a change works with the verification skill in [`.agents/skills/verify-dms-database/SKILL.md`](.agents/skills/verify-dms-database/SKILL.md) before you call it done.

That line is an agent-skill call site, which the brief leaves to the deletion step, so this PR keeps it. The deletion is therefore the folder removal plus pnpm sync. Here is the same run with that synced AGENTS.md in place, and the folder still moved away:

$ pnpm exec antelopejs-sync && pnpm run checks
Checks: 13 passed, 0 failed.
flowchart LR
  T[feature-map.test.ts] -->|before| S[.agents/skills/verify-dms-database<br/>verify.config.ts + features/*.md]
  T -->|after| J[e2e/features.json]
  T --> E[e2e/journeys/*.mjs]
Loading

What still references the folder

These are agent-facing docs only, and they go with the skill's deletion:

  • AGENTS.md:46 points to the verification skill's SKILL.md. antelopejs-sync drops it once the folder is gone.
  • .agents/skills/formal-table-watch/SKILL.md names the extending feature of verify-dms-database, dms-control formal, and the formal list of verify.config.ts.
  • The skill's own features/README.md still says feature-map.test.ts checks its files. Its covers: lists now duplicate e2e/features.json until the folder is removed.

e2e/playground keeps the names verify-dms-database (in antelope.config.ts) and verify-dms-database-app (in package.json). They are project and package names, not paths.

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 19, 2026 11:49
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit e85ccbc Nov 19, 2026
12 checks passed
@Upd4ting
Upd4ting deleted the test/wdf26acfc-106-off-verify-harness branch November 19, 2026 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant