Skip to content

fix(data): show undo_failed when an undo restores nothing - #221

Merged
Upd4ting merged 3 commits into
mainfrom
fix/wdf26acfc-151
Nov 19, 2026
Merged

Upd4ting merged 3 commits into
mainfrom
fix/wdf26acfc-151

Conversation

@Upd4ting

Copy link
Copy Markdown
Member

Wdf26acfc-151: dms_database.data.save.undo_failed was defined in both locales but never shown; a wholly failed undo showed undo_partial.

Changes

  • useStagedSave.undo uses undo_failed as the fallback message when the undo restored nothing and no row is gone, and keeps undo_partial for a partial failure.

Proof

flowchart TD
  A[undo writes rows back] --> B{rows left?}
  B -- no --> C[undone notice]
  B -- yes --> D{restored or gone rows?}
  D -- none --> E[undo_failed]
  D -- some --> F[undo_partial]
Loading

No unit test: the composable relies on Nuxt auto-imports and has no existing test harness. ESLint and Prettier pass on the file.

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 19, 2026 21:34
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 19, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Nov 19, 2026
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit 15be3b0 Nov 19, 2026
12 checks passed
@Upd4ting
Upd4ting deleted the fix/wdf26acfc-151 branch November 19, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant