Repository navigation
ci: export and cache both the dms-control and dms-e2e names - #160
Merged
Merged
Conversation
Upd4ting
marked this pull request as ready for review
November 19, 2026 23:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Wdf26acfc-172.
Summary
dms #1184 renamed the e2e kit's cache folders and env vars with no fallback. The e2e job now exports
DMS_CONTROL_RUNSandDMS_E2E_RUNS, and caches both~/.cache/dms-control/frontendand~/.cache/dms-e2e/frontendunder a new key prefix (dms-e2e-frontend-v2-) that does not collide with the old one. A note in the workflow says the dms-control names go once the repo is on a dms release with #1184.DMS_CONTROL_MONGODandDMS_CONTROL_NO_STANDBYare not used in this repo.Proof
Before:
grep -rnE "DMS_CONTROL_|dms-control"hit one export, no dms-e2e twin. After: the export and the cache path each have their twin (see diff).Follow-ups