Repository navigation
fix(test): read the packed tarball from its folder on Windows - #161
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wec9b4589-24. The nightly
ci / Node .nvmrc on Windows(run 44660718684) fails intests/package.test.mjs:readPackedreturned empty text, soJSON.parsethrew "Unexpected end of JSON input" and the four tarball tests were cancelled. The pack itself works (npm packalready runs with a shell on win32). The cause istarfrom Git for Windows (GNU tar) reading the absoluteD:\...tarball path ashost:path, so it extracted nothing and the test ignored the exit status.The helper now runs
tarwithcwdset to the pack folder and the bare tarball name, asserts eachtarexits 0, and splits output on\r?\n.Related issue
ANT-3515 (nightly failure).
Verification
SyntaxError: Unexpected end of JSON input at pack (tests/package.test.mjs:60).distbuilt):node --test tests/package.test.mjsruns 3 of 4 tests as before; the fourth fails only becausedistis not built here.nightlyonly forschedule), so the proof is the next 02:17 UTC scheduled nightly. The manual run on this branch (https://github.com/AntelopeJS/dms-lang/actions/runs/44825996953) passed its Linux Node and Extra legs.Follow-ups
Checklist