Skip to content

feat(dms-mailing): add cc and a per-send reply-to to template e-mails - #213

Merged
Upd4ting merged 3 commits into
mainfrom
feat/w05057e83-11-cc-reply-to
Nov 20, 2026
Merged

Upd4ting merged 3 commits into
mainfrom
feat/w05057e83-11-cc-reply-to

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

W05057e83-11. SendTemplate now takes cc and a per-send replyTo. @antelopejs/interface-email already accepts both, but template mails had no way to set them (Altab dashboard report).

  • SendTemplateParams.cc?: EmailAddress[] is copied on every message. A cc address on the suppression list is dropped, and the send row keeps the copied ones in json_cc.
  • SendTemplateParams.replyTo?: EmailAddress overrides the workspace reply-to from settings.
  • No bcc. The address helpers duplicated in send.ts and checked-send.ts move to services/addresses.ts, which keeps send.ts under the line cap.

⚠ sensitive: adds the stored field json_cc and two fields to the public SendTemplateParams

Related issue

Maxime's blocker report on the Altab v2 dashboard, reviewed by Antony.

Verification

  • pnpm run typecheck: clean.
  • pnpm --dir packages/dms-mailing test:backend: 608 passing.
  • New unit tests (send.test.ts): messageFor passes cc; a per-send replyTo beats the workspace one, which still applies without it.
  • New integration test (send-cc-reply-to.test.ts): the SMTP message carries Cc and Reply-To, json_cc is logged, and a suppressed cc address is absent from the message and the log. Without the suppression filter that test fails, since the address would be in Cc.
flowchart LR
  P[SendTemplate params: to, cc, replyTo] --> S[sendUnlessSuppressed]
  S -->|drop suppressed cc| T[sendTemplate]
  T --> M[messageFor: replyTo ?? workspace replyTo]
  M --> E[interface-email Send]
  T --> L[send row: json_cc]
Loading

Follow-ups

  • none

Checklist

  • The pull request title follows Conventional Commits.
  • I added or updated tests when behavior changed.
  • I updated documentation when users or contributors are affected.
  • I documented breaking changes and migration steps: none, both fields are optional.
  • I did not include credentials or unrelated changes.

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 18:25
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit fa99a05 Nov 20, 2026
13 checks passed
@Upd4ting
Upd4ting deleted the feat/w05057e83-11-cc-reply-to branch November 20, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant