Repository navigation
feat(dms-mailing): add cc and a per-send reply-to to template e-mails - #213
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
W05057e83-11.
SendTemplatenow takesccand a per-sendreplyTo.@antelopejs/interface-emailalready accepts both, but template mails had no way to set them (Altab dashboard report).SendTemplateParams.cc?: EmailAddress[]is copied on every message. A cc address on the suppression list is dropped, and the send row keeps the copied ones injson_cc.SendTemplateParams.replyTo?: EmailAddressoverrides the workspace reply-to from settings.bcc. The address helpers duplicated insend.tsandchecked-send.tsmove toservices/addresses.ts, which keepssend.tsunder the line cap.⚠ sensitive: adds the stored field json_cc and two fields to the public SendTemplateParams
Related issue
Maxime's blocker report on the Altab v2 dashboard, reviewed by Antony.
Verification
pnpm run typecheck: clean.pnpm --dir packages/dms-mailing test:backend: 608 passing.send.test.ts):messageForpassescc; a per-sendreplyTobeats the workspace one, which still applies without it.send-cc-reply-to.test.ts): the SMTP message carriesCcandReply-To,json_ccis logged, and a suppressed cc address is absent from the message and the log. Without the suppression filter that test fails, since the address would be inCc.Follow-ups
Checklist