Skip to content

test(dms-mailing): give the journeys cleanup hook a timeout sized for Windows - #214

Merged
Upd4ting merged 1 commit into
mainfrom
test/wec9b4589-25-windows-cleanup-hook
Nov 20, 2026
Merged

Upd4ting merged 1 commit into
mainfrom
test/wec9b4589-25-windows-cleanup-hook

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Summary

Wec9b4589-25. The nightly backend-tests on Windows failed on 2026-11-20 (run 44660678952): the root after hook removeRunUnlessFailed hit mocha's 2000 ms default while rmSync removed the run folder, which is slow on Windows. The hook now removes the folder with async rm and carries the same 30 s timeout as the journeys' reset hooks.

Related issue

Wec9b4589-25 (brief only, no Notion page); nightly failure listed from ANT-3515.

Verification

  • pnpm run typecheck, oxlint and oxfmt --check on the changed file pass.
  • A manual run cannot reach the nightly tier (the shared ci-tier action returns nightly only for schedule), so the proof is the next scheduled nightly; the pull request merges on its own checks.

Before (nightly run 44660678952, Windows leg):

1) "after all" hook: removeRunUnlessFailed in "{root}":
   Error: Timeout of 2000ms exceeded.
flowchart LR
  A[last journey ends] --> B[root after hook]
  B -->|before| C[rmSync blocks, 2000 ms limit]
  B -->|after| D[await rm, 30 s limit]
Loading

Follow-ups

  • none

Checklist

  • The pull request title follows Conventional Commits.
  • I added or updated tests when behavior changed. (test helper only)
  • I updated documentation when users or contributors are affected. (n/a)
  • I documented breaking changes and migration steps. (none)
  • I did not include credentials or unrelated changes.

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 22:16
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit d648eb3 Nov 20, 2026
32 checks passed
@Upd4ting
Upd4ting deleted the test/wec9b4589-25-windows-cleanup-hook branch November 20, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant