Repository navigation
test(dms-mailing): give the journeys cleanup hook a timeout sized for Windows - #214
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wec9b4589-25. The nightly
backend-tests on Windowsfailed on 2026-11-20 (run 44660678952): the rootafterhookremoveRunUnlessFailedhit mocha's 2000 ms default whilermSyncremoved the run folder, which is slow on Windows. The hook now removes the folder with asyncrmand carries the same 30 s timeout as the journeys' reset hooks.Related issue
Wec9b4589-25 (brief only, no Notion page); nightly failure listed from ANT-3515.
Verification
pnpm run typecheck,oxlintandoxfmt --checkon the changed file pass.nightlyonly forschedule), so the proof is the next scheduled nightly; the pull request merges on its own checks.Before (nightly run 44660678952, Windows leg):
Follow-ups
Checklist