Repository navigation
test: give each orderBy array-key case its own timeout - #164
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wec9b4589-16: fix the nightly
ci / Stressfailure ofgroup mapper orderBy on an array key.Summary
The test ran 205 cases (5 fixed, 200 seeded) in a single
it, so one 10000 ms mocha timeout covered all of them. On a slow or loaded host (Stress runs--timeout 10000) the sum passes 10 s. Each case now is its ownit, so the budget is per case and no longer scales with host speed or case count. Coverage is unchanged.Proof
Before: nightly runs 44002941526, 44223246529, 44444237277 and 44660695989 failed with
1) group mapper orderBy on an array key — Timeout of 10000ms exceeded.After:
ajs module test . --timeout 10000 -f dist/test/group-orderby-array-sort.test.jsgives208 passing (7s).Local reproduction beside 2 busy loops per CPU (far heavier than CI): before, the file fails with 3 timeouts, 2 tests passing; after, 207 passing, 2 timeouts. The per-case split removes the aggregate-budget failure but cannot make a test immune to a host oversubscribed 2x. The nightly tier cannot be dispatched manually (ci-tier returns
nightlyonly forschedule), so the next 02:17 UTC scheduled nightly is the proof.Follow-ups