Skip to content

test: give each orderBy array-key case its own timeout - #164

Merged
Upd4ting merged 1 commit into
mainfrom
test/wec9b4589-16-orderby-array-stress
Nov 20, 2026
Merged

Upd4ting merged 1 commit into
mainfrom
test/wec9b4589-16-orderby-array-stress

Conversation

@Upd4ting

@Upd4ting Upd4ting commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Wec9b4589-16: fix the nightly ci / Stress failure of group mapper orderBy on an array key.

Summary

The test ran 205 cases (5 fixed, 200 seeded) in a single it, so one 10000 ms mocha timeout covered all of them. On a slow or loaded host (Stress runs --timeout 10000) the sum passes 10 s. Each case now is its own it, so the budget is per case and no longer scales with host speed or case count. Coverage is unchanged.

Proof

Before: nightly runs 44002941526, 44223246529, 44444237277 and 44660695989 failed with 1) group mapper orderBy on an array key — Timeout of 10000ms exceeded.
After: ajs module test . --timeout 10000 -f dist/test/group-orderby-array-sort.test.js gives 208 passing (7s).

flowchart LR
  A[before: 1 it] --> B[205 cases share one 10 s budget] --> C[timeout under load]
  D[after: 205 it] --> E[10 s budget per case] --> F[pass]
Loading

Local reproduction beside 2 busy loops per CPU (far heavier than CI): before, the file fails with 3 timeouts, 2 tests passing; after, 207 passing, 2 timeouts. The per-case split removes the aggregate-budget failure but cannot make a test immune to a host oversubscribed 2x. The nightly tier cannot be dispatched manually (ci-tier returns nightly only for schedule), so the next 02:17 UTC scheduled nightly is the proof.

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 22:14
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 147df9e Nov 20, 2026
16 checks passed
@Upd4ting
Upd4ting deleted the test/wec9b4589-16-orderby-array-stress branch November 20, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant