Skip to content

test(catalog): run the shared fewer-than-5 profile check - #125

Merged
Upd4ting merged 2 commits into
mainfrom
test/wec9b4589-6-shared-profile-test
Nov 20, 2026
Merged

Upd4ting merged 2 commits into
mainfrom
test/wec9b4589-6-shared-profile-test

Conversation

@Upd4ting

Copy link
Copy Markdown
Member

Summary

Wec9b4589-6 (ANT-3517 adoption). The external-mode range tests now run the shared AssertNoRareValue check from @antelopejs/interface-database-catalog/testing instead of their own include/not.include string assertions. The package is pinned to 0.1.1-next.44.gee21aa3. Received also returns the captured result sets parsed, which the shared check takes. tsconfig.json maps the /testing subpath so the module resolves under commonjs.

Proof

The shared check fails when the fixture counts 7002 4 times instead of 5 (temporary mutation, MYSQL_TEST_MODE=external):

  3 passing
  1 failing
  1) ends an integer column at values seen 5 times, past values seen 4 times:
     Error: The profile of sales.grades names rare values:
level range min names 7002 (level, counted 4 times)
level categories names 7002 (level, counted 4 times)
result set 12 names 7002 (level, counted 4 times)

Unmutated, on MySQL 8.4: 4 passing.

flowchart LR
  T[ranges.test.ts] -->|Profile| D[mysql driver]
  D -->|queries| DB[(fixture)]
  D -->|result sets| R[Received tap]
  R --> A[AssertNoRareValue]
  D -->|RelationProfile| A
  F[FIXTURE_COUNTS] --> A
Loading

Related issue

ANT-3517

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 22:01
@Upd4ting
Upd4ting enabled auto-merge November 20, 2026 22:01
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 68e8c0a Nov 20, 2026
7 checks passed
@Upd4ting
Upd4ting deleted the test/wec9b4589-6-shared-profile-test branch November 20, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant