Skip to content

test(external-mode): run the shared fewer-than-5 profile check - #112

Merged
Upd4ting merged 1 commit into
mainfrom
test/wec9b4589-5-shared-profile-test
Nov 20, 2026
Merged

Upd4ting merged 1 commit into
mainfrom
test/wec9b4589-5-shared-profile-test

Conversation

@Upd4ting

Copy link
Copy Markdown
Member

Summary

Wec9b4589-5 (ANT-3517). The external-mode ranges suite now calls AssertNoRareValue from @antelopejs/interface-database-catalog/testing (interface-database-catalog#43) against the profile postgres answered, the result sets its Received tap captured, and the per-value counts of the sales.grades fixture. The hand-written not.include("bronze" / "platinum" / "7001" / "7009") checks are gone.

  • Pins @antelopejs/interface-database-catalog@0.1.1-next.44.gee21aa3 (exact, in dependencies; README compatibility table synced).
  • tsconfig.json gets a paths entry so the /testing subpath resolves under module: commonjs.
  • The result set holding the enum's declared labels is left out of results, as the shared check's docs say a legitimate one should be.

Proof

The shared check replaces the local copy and passes on postgres' own profile output:

$ PG_TEST_MODE=external pnpm exec ajs module test . -f dist/test-external/ranges.test.js
  5 passing

pnpm exec antelopejs-checks: 13 passed, 0 failed.

flowchart LR
  T[ranges.test] -->|Profile| P[postgres]
  P -->|queries| DB[(sales.grades)]
  DB -->|rows| R[Received tap]
  P -->|RelationProfile| A[AssertNoRareValue]
  R -->|results| A
  F[GRADE_COUNTS] -->|counts| A
  A -->|throws on a value counted < 5| T
Loading

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 22:01
@Upd4ting
Upd4ting enabled auto-merge November 20, 2026 22:01
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit 85c658c Nov 20, 2026
8 of 11 checks passed
@Upd4ting
Upd4ting deleted the test/wec9b4589-5-shared-profile-test branch November 20, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant