Skip to content

test: run the shared fewer-than-5 profile check - #128

Merged
Upd4ting merged 3 commits into
mainfrom
test/wec9b4589-8-shared-profile-test
Nov 20, 2026
Merged

Upd4ting merged 3 commits into
mainfrom
test/wec9b4589-8-shared-profile-test

Conversation

@Upd4ting

Copy link
Copy Markdown
Member

Summary

Wec9b4589-8 (from ANT-3517). The external ranges test ran its own copy of the fewer-than-5 rule (received must not include 7001). It now calls AssertNoRareValue from @antelopejs/interface-database-catalog/testing, with the profile the driver answered, the values its Received tap captured, and the per-value counts of the grades.level fixture. The package is pinned to 0.1.1-next.44.gee21aa3; tsconfig.json maps the /testing subpath so the CommonJS resolution finds its types.

Proof

Before the change the check lived only as expect(received).to.not.include(...). With the shared check and the fixture counting 7002 as 4 rows, the test fails:

1) the range of an external number field
   Error: The profile of erp_test.grades names rare values:
level range min names 7002 (level, counted 4 times)
level categories names 7002 (level, counted 4 times)
result set 110 names 7002 (level, counted 4 times)

With the real fixture counts: pnpm test:external 62 passing.

flowchart LR
  T[ranges test] -->|Profile| D[rethinkdb catalog]
  D -->|net socket| R[Received tap]
  D -->|RelationProfile| A[AssertNoRareValue]
  R -->|ReceivedValues| A
  F[GRADE_LEVEL_COUNTS] --> A
Loading

Related issue

ANT-3517

Follow-ups

  • none

@Upd4ting
Upd4ting marked this pull request as ready for review November 20, 2026 21:59
@Upd4ting
Upd4ting enabled auto-merge November 20, 2026 21:59
@Upd4ting
Upd4ting added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit fdd7403 Nov 20, 2026
7 checks passed
@Upd4ting
Upd4ting deleted the test/wec9b4589-8-shared-profile-test branch November 20, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant