Repository navigation
fix(build): require libuvcpp 1.9.1 - #27
Merged
Merged
Conversation
The HTTP/2 terminal route calls app_.websocket_connect(), which is newer than the 1.8.2 SDK used by the release workflow. All platform jobs in the v1.0.2 release run failed to compile application.cpp. Build and require libuvcpp 1.9.1, update the SDK documentation and note the dependency change in the 1.0.2 changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v1.0.2 Release workflow builds libuvcpp via
scripts/build-libuvcpp.sh,which pinned
v1.8.2. That SDK predatesapp_.websocket_connect()anduvcpp_web_ws_session, soapplication.cppfailed to compile in everyplatform job — the terminal fix requires the h2/h3 WebSocket route.
Build and require libuvcpp 1.9.1, and update the SDK documentation and the
1.0.2 changelog.
Testing
application.cppwith "no member named websocket_connect".